Page MenuHomePhabricator

[DebugInfo] Fix build failure on the mingw
ClosedPublic

Authored by djtodoro on Mar 11 2020, 12:29 AM.

Details

Reviewers
vsk
aprantl
dstenb
Summary

Add the workaround for the X86::MOV16ri when describing call site
parameters.

The D75326 should really create the Debug Info for the call site parameter.

Diff Detail

Event Timeline

djtodoro created this revision.Mar 11 2020, 12:29 AM

Thanks, this seems like a good workaround to get rid of the assertion until D75326 has landed.

llvm/test/DebugInfo/MIR/X86/call-site-param-mov16.mir
3

With -filetype=obj -o - the binary data will be emitted on stdout when running llvm-lit -a.

WDYT about adding a llvm-dwarfdump FileCheck that checks that there are no call site parameter entries emitted?

djtodoro updated this revision to Diff 249568.Mar 11 2020, 2:25 AM

-Improving the test

djtodoro marked an inline comment as done.Mar 11 2020, 2:25 AM
djtodoro added inline comments.
llvm/test/DebugInfo/MIR/X86/call-site-param-mov16.mir
3

Makes sense to me, thanks!

dstenb accepted this revision.Mar 11 2020, 3:35 AM

LGTM

This revision is now accepted and ready to land.Mar 11 2020, 3:35 AM
aprantl added inline comments.Mar 11 2020, 9:27 AM
llvm/test/DebugInfo/MIR/X86/call-site-param-mov16.mir
3

Comment what is being tested here?

djtodoro updated this revision to Diff 249658.Mar 11 2020, 9:45 AM

-Improve the test

djtodoro marked an inline comment as done.Mar 11 2020, 9:45 AM
djtodoro added inline comments.
llvm/test/DebugInfo/MIR/X86/call-site-param-mov16.mir
3

Sure. Thanks!

aprantl accepted this revision.Mar 11 2020, 3:04 PM
djtodoro closed this revision.Mar 12 2020, 12:50 AM

Closed with the 3b984641a737.