Page MenuHomePhabricator

[mlir] Add support for non-identifier attribute names.
ClosedPublic

Authored by rriddle on Mar 10 2020, 10:43 PM.

Details

Summary

In some situations the name of the attribute is not representable as a bare-identifier, this revision adds support for those cases by formatting the name as a string instead. This has the added benefit of removing the identifier regex from the verifier.

Diff Detail

Event Timeline

rriddle created this revision.Mar 10 2020, 10:43 PM
silvas accepted this revision.Mar 11 2020, 9:35 AM
silvas added a subscriber: silvas.

Nice improvement! Thanks for the quick turnaround :)

mlir/lib/IR/AsmPrinter.cpp
1622

nit: '"' for consistency with below

This revision is now accepted and ready to land.Mar 11 2020, 9:35 AM
rriddle updated this revision to Diff 249741.Mar 11 2020, 1:20 PM

Resolve comments

rriddle marked an inline comment as done.Mar 11 2020, 1:21 PM
This revision was automatically updated to reflect the committed changes.