[llvm-objdump] Simplify conditional statements (isa<...>(Obj) => Obj->isSomeFile())

[Higuoxing]

Summary

Simplify some conditional statements.

[Higuoxing]

Rebase.

llvm/tools/llvm-objdump/llvm-objdump.cpp

 
 // Used for --adjust-vma to check if address should be adjusted by the
 // specified value for a given section.
 // For ELF we do not adjust non-allocatable sections like debug ones,
 // because they are not loadable.
 // TODO: implement for other file formats.
 static bool shouldAdjustVA(const SectionRef &Section) {
   const ObjectFile *Obj = Section.getObject();
-  if (isa<object::ELFObjectFileBase>(Obj))
+  if (Obj->isELF())
     return ELFSectionRef(Section).getFlags() & ELF::SHF_ALLOC;
   return false;
 }
 
 
 typedef std::pair<uint64_t, char> MappingSymbolPair;
 static char getMappingSymbolKind(ArrayRef<MappingSymbolPair> MappingSymbols,
                                  uint64_t Address) {
void printSymbol(const ObjectFile *O, const SymbolRef &Symbol,
   bool Absolute = Flags & SymbolRef::SF_Absolute;
   bool Common = Flags & SymbolRef::SF_Common;
   bool Hidden = Flags & SymbolRef::SF_Hidden;
 
   char GlobLoc = ' ';
   if ((Section != O->section_end() || Absolute) && !Weak)
     GlobLoc = Global ? 'g' : 'l';
   char IFunc = ' ';
-  if (isa<ELFObjectFileBase>(O)) {
+  if (O->isELF()) {
     if (ELFSymbolRef(Symbol).getELFType() == ELF::STT_GNU_IFUNC)
       IFunc = 'i';
     if (ELFSymbolRef(Symbol).getBinding() == ELF::STB_GNU_UNIQUE)
       GlobLoc = 'u';
   }
 
   char Debug = ' ';
   if (DumpDynamic)
outs() << format(Fmt, Address) << " "
          << ' ';
   if (Absolute) {
     outs() << "*ABS*";
   } else if (Common) {
     outs() << "*COM*";
   } else if (Section == O->section_end()) {
     outs() << "*UND*";
   } else {
-    if (const MachOObjectFile *MachO = dyn_cast<const MachOObjectFile>(O)) {
+    if (MachO) {
       DataRefImpl DR = Section->getRawDataRefImpl();
       StringRef SegmentName = MachO->getSectionFinalSegmentName(DR);
       outs() << SegmentName << ",";
     }
     StringRef SectionName = unwrapOrError(Section->getName(), FileName);
     outs() << SectionName;
   }
 
-  if (Common || isa<ELFObjectFileBase>(O)) {
+  if (Common || O->isELF()) {
     uint64_t Val =
         Common ? Symbol.getAlignment() : ELFSymbolRef(Symbol).getSize();
     outs() << '\t' << format(Fmt, Val);
   }
 
-  if (isa<ELFObjectFileBase>(O)) {
+  if (O->isELF()) {
     uint8_t Other = ELFSymbolRef(Symbol).getOther();
     switch (Other) {
     case ELF::STV_DEFAULT:
       break;
     case ELF::STV_INTERNAL:
       outs() << " .internal";
       break;
     case ELF::STV_HIDDEN:
WithColor::error(errs(), ToolName)
         << "The -raw-clang-ast option will dump the raw binary contents of "
            "the clang ast section.\n"
            "Please redirect the output to a file or another program such as "
            "llvm-bcanalyzer.\n";
     return;
   }
 
   StringRef ClangASTSectionName("__clangast");
-  if (isa<COFFObjectFile>(Obj)) {
+  if (Obj->isCOFF()) {
     ClangASTSectionName = "clangast";
   }
 
   Optional<object::SectionRef> ClangASTSection;
   for (auto Sec : ToolSectionFilter(*Obj)) {
     StringRef Name;
     if (Expected<StringRef> NameOrErr = Sec.getName())
       Name = *NameOrErr;
void printRawClangAST(const ObjectFile *Obj) {
   StringRef ClangASTContents = unwrapOrError(
       ClangASTSection.getValue().getContents(), Obj->getFileName());
   outs().write(ClangASTContents.data(), ClangASTContents.size());
 }
 
 static void printFaultMaps(const ObjectFile *Obj) {
   StringRef FaultMapSectionName;
 
-  if (isa<ELFObjectFileBase>(Obj)) {
+  if (Obj->isELF()) {
     FaultMapSectionName = ".llvm_faultmaps";
-  } else if (isa<MachOObjectFile>(Obj)) {
+  } else if (Obj->isMachO()) {
     FaultMapSectionName = "__llvm_faultmaps";
   } else {
     WithColor::error(errs(), ToolName)
         << "This operation is only currently supported "
            "for ELF and Mach-O executable files.\n";
     return;
   }