The logic in select_cc is messy and hard to follow. This is a NFC patch to simplify the logic.
Details
Details
- Reviewers
nemanjai ZhangKang - Group Reviewers
Restricted Project - Commits
- rG0b126eec6d46: [NFC][PowerPC] Simplify the logic in lower select_cc
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/PowerPC/PPCISelLowering.cpp | ||
---|---|---|
7543–7547 | Above comments should be splitted into 2 parts // We might be able to do better than this under some circumstances, but in // general, fsel-based lowering of select is a finite-math-only optimization. // For more information, see section F.3 of the 2.06 ISA specification. The other is below, it should before the line 7556. // With ISA 3.0, we have xsmaxcdp/xsmincdp which are OK to emit even in the // presence of infinities. You patch is similar without the patch https://reviews.llvm.org/D62993 . |
Above comments should be splitted into 2 parts
One is below, it should before the line 7569.
The other is below, it should before the line 7556.
You patch is similar without the patch https://reviews.llvm.org/D62993 .