This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Add .clang-tidy with customization to disable readability-identifier-naming
ClosedPublic

Authored by MaskRay on Mar 7 2020, 9:34 AM.

Diff Detail

Event Timeline

MaskRay created this revision.Mar 7 2020, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2020, 9:34 AM

https://github.com/google/llvm-premerge-checks/issues/142 This should suppress the annoying clang-tidy linux diagnostics in Diff Detail - Build Status.

labath added a comment.Mar 9 2020, 5:39 AM

Yeah, naming conventions in lldb have always been a controversial topic. Most of the code uses the lldb convention, but some of the new code (particularly if it interfaces with llvm a lot) uses more llvm-like conventions. I think we used to have a description of the naming convention somewhere on the website. That is no longer there, but neither do we have a plan for migration.

I don't really know what that means for this patch...

Yeah, naming conventions in lldb have always been a controversial topic. Most of the code uses the lldb convention, but some of the new code (particularly if it interfaces with llvm a lot) uses more llvm-like conventions. I think we used to have a description of the naming convention somewhere on the website. That is no longer there, but neither do we have a plan for migration.

I don't really know what that means for this patch...

I would exclude readability-identifier-naming from the list of checks.

MaskRay updated this revision to Diff 249139.Mar 9 2020, 9:44 AM
MaskRay retitled this revision from [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function,Member,Parameter,Variable}Case to [lldb] Add .clang-tidy with customization to disable readability-identifier-naming.

Disable readability-identifier-naming

JDevlieghere accepted this revision.Mar 9 2020, 10:31 AM
This revision is now accepted and ready to land.Mar 9 2020, 10:31 AM
This revision was automatically updated to reflect the committed changes.