This is an archive of the discontinued LLVM Phabricator instance.

Make malign-double effective only for x86
AbandonedPublic

Authored by MaskRay on Mar 7 2020, 4:44 AM.

Details

Reviewers
rnk
kamleshbhalui
Summary

Making -malign-double effective only for x86.

Fixes.
https://bugs.llvm.org/show_bug.cgi?id=45136

Diff Detail

Event Timeline

kamleshbhalui created this revision.Mar 7 2020, 4:44 AM
kamleshbhalui added a reviewer: MaskRay.
MaskRay added a comment.EditedMar 9 2020, 8:46 AM

-Xclang -malign-double passes a CC1 option. This is like poking into the compiler internals. The interface is not stable, and some flags may not make sense (they can be precluded by clang/lib/Driver logic), so I am not sure why it is reported as a bug in the first place.

edit: The problem is that Opts.AlignDouble in TargetInfo.cpp needs some adaptation to make it work for aarch64_32. I will on a patch.

I think we should just add aarch64_32 support when it becomes clearer how aarch64_32 needs -malign-double.

MaskRay requested changes to this revision.Jun 12 2023, 9:09 PM
This revision now requires changes to proceed.Jun 12 2023, 9:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 9:09 PM
Herald added a subscriber: pengfei. · View Herald Transcript
MaskRay commandeered this revision.Jun 12 2023, 9:09 PM
MaskRay edited reviewers, added: kamleshbhalui; removed: MaskRay.
This revision now requires review to proceed.Jun 12 2023, 9:09 PM
MaskRay abandoned this revision.Jun 12 2023, 9:09 PM