This is an archive of the discontinued LLVM Phabricator instance.

[mlir] NFC - Add predicates and types for VectorOfRank
ClosedPublic

Authored by nicolasvasilache on Mar 6 2020, 2:34 PM.

Details

Summary

This is the counterpart of VectorOfLength for ranks.
This will be used in lowering vector.contract operations to llvm.matrix

Diff Detail

Event Timeline

Herald added 1 blocking reviewer(s): rriddle. · View Herald TranscriptMar 6 2020, 2:34 PM
Herald added a project: Restricted Project. · View Herald Transcript
aartbik accepted this revision.Mar 9 2020, 9:30 AM
aartbik added inline comments.
mlir/include/mlir/IR/OpBase.td
490

It does not look like the surrounding methods are consistent on this, but given that rank is int64_t (and unsigned at other places), consider a similar type for this; but perhaps this is more for a follow-up cleanup of our types

This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2020, 10:14 AM
This revision was automatically updated to reflect the committed changes.