Page MenuHomePhabricator

Split findUnwindSectionsByPhdr into target-specific functions.
ClosedPublic

Authored by saugustine on Mar 5 2020, 11:53 AM.

Details

Summary

This further cleans up the control flow and makes it easier to
optimize and replace portions in a subsequent patch.

This should be NFC, but given the amount of #ifdeffing here,
it may not be. So will watch the buildbots closely.

Also, as this is purely moving existing code around, I plan to
ignore the lint errors.

Diff Detail

Event Timeline

saugustine created this revision.Mar 5 2020, 11:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2020, 11:53 AM

I don't know why the linter wants me to indent everything another level. That is clearly not right given the surrounding code.

This file seems to long predate the style guide and lint rules, so most of these reports are not useful.

jgorbe accepted this revision.Mar 6 2020, 12:17 PM
jgorbe added a subscriber: jgorbe.

As far as I can tell (there is indeed a lot of ifdeffing going on, please keep an eye on the buildbots) this change seems to be both NFC and an improvement to the previous state, so LGTM.

This revision is now accepted and ready to land.Mar 6 2020, 12:17 PM
This revision was automatically updated to reflect the committed changes.