This is an archive of the discontinued LLVM Phabricator instance.

Differential D75658

Add test comments about missing section names and only having file/offset
AbandonedPublic

Authored by rupprecht on Mar 4 2020, 4:16 PM.

Details

Reviewers
• espindola
jhenderson

Diff Detail

Event Timeline

rupprecht created this revision.Mar 4 2020, 4:16 PM
Herald added a reviewer: • espindola. · View Herald TranscriptMar 4 2020, 4:16 PM
Herald added a reviewer: jhenderson. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, MaskRay, emaste. · View Herald Transcript
MaskRay added a comment.Mar 4 2020, 4:58 PM

The change should be merged into D75647 because currently Name is not dumped.

MaskRay added a comment.EditedMar 4 2020, 4:59 PM

it is stripped

The section header table is not present.

rupprecht abandoned this revision.Mar 4 2020, 6:48 PM
In D75658#1906729, @MaskRay wrote:

The change should be merged into D75647 because currently Name is not dumped.

Yeah, not sure what's going on. arc diff created this instead of updating the existing one.
Addressed the comment in the other patch.

Harbormaster completed remote builds in B48134: Diff 248354.Mar 4 2020, 7:03 PM

Revision Contents

PathSize
llvm/
test/
tools/
llvm-readobj/
ELF/
2 lines

Diff 248354

llvm/test/tools/llvm-readobj/ELF/gnu-notes.test

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
# LLVM-NEXT: Owner: GNU # LLVM-NEXT: Owner: GNU
# LLVM-NEXT: Data size: 0x9 # LLVM-NEXT: Data size: 0x9
# LLVM-NEXT: Type: NT_GNU_GOLD_VERSION (gold version) # LLVM-NEXT: Type: NT_GNU_GOLD_VERSION (gold version)
# LLVM-NEXT: Version: gold 1.11 # LLVM-NEXT: Version: gold 1.11
# LLVM-NEXT: } # LLVM-NEXT: }
# LLVM-NEXT: } # LLVM-NEXT: }
# LLVM-NEXT: ] # LLVM-NEXT: ]
## Note: there is no "Name: .note.gnu.build-id" assertion here because it is stripped.
# LLVM-STRIPPED: Notes [ # LLVM-STRIPPED: Notes [
# LLVM-STRIPPED-NEXT: NoteSection { # LLVM-STRIPPED-NEXT: NoteSection {
# LLVM-STRIPPED-NEXT: Offset: 0x78 # LLVM-STRIPPED-NEXT: Offset: 0x78
# LLVM-STRIPPED-NEXT: Size: 0x20 # LLVM-STRIPPED-NEXT: Size: 0x20
# LLVM-STRIPPED-NEXT: Note { # LLVM-STRIPPED-NEXT: Note {
# LLVM-STRIPPED-NEXT: Owner: GNU # LLVM-STRIPPED-NEXT: Owner: GNU
# LLVM-STRIPPED-NEXT: Data size: 0x10 # LLVM-STRIPPED-NEXT: Data size: 0x10
# LLVM-STRIPPED-NEXT: Type: NT_GNU_BUILD_ID (unique build ID bitstring) # LLVM-STRIPPED-NEXT: Type: NT_GNU_BUILD_ID (unique build ID bitstring)
# LLVM-STRIPPED-NEXT: Build ID: 4fcb712aa6387724a9f465a32cd8c14b # LLVM-STRIPPED-NEXT: Build ID: 4fcb712aa6387724a9f465a32cd8c14b
# LLVM-STRIPPED-NEXT: } # LLVM-STRIPPED-NEXT: }
# LLVM-STRIPPED-NEXT: } # LLVM-STRIPPED-NEXT: }
# LLVM-STRIPPED-NEXT: ] # LLVM-STRIPPED-NEXT: ]
## Note: offset and length printed instead of "found in: .note.gnu.build-id" because it is stripped.
# GNU-STRIPPED:Displaying notes found at file offset 0x00000078 with length 0x00000020: # GNU-STRIPPED:Displaying notes found at file offset 0x00000078 with length 0x00000020:
# GNU-STRIPPED-NEXT: Owner Data size Description # GNU-STRIPPED-NEXT: Owner Data size Description
# GNU-STRIPPED-NEXT: GNU 0x00000010 NT_GNU_BUILD_ID (unique build ID bitstring) # GNU-STRIPPED-NEXT: GNU 0x00000010 NT_GNU_BUILD_ID (unique build ID bitstring)
# GNU-STRIPPED-NEXT: Build ID: 4fcb712aa6387724a9f465a32cd8c14b # GNU-STRIPPED-NEXT: Build ID: 4fcb712aa6387724a9f465a32cd8c14b
--- !ELF --- !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines