Page MenuHomePhabricator

[x86][slh][NFC] Rm redundant liveness check
ClosedPublic

Authored by zbrid on Mar 4 2020, 3:00 PM.

Details

Summary

In this changeset (https://reviews.llvm.org/D70283), I added a liveness
check everywhere the isDataInvariant* functions were used, so that I
could safely delete the checks within the function. I mistakenly left
that deletion out of the patch. The result is that the same condition is
checked twice for some instructions which is functionally fine, but not
good. This change deletes the redundant check that I intended to delete
in the last change.

This is the second of three patches that will make the data invariance
checks available for non-SLH passes and enable the FIXMEs related to
moving this metadata to the instruction tables to be resolved.

Tested via llvm-lit llvm/test/CodeGen/X86/speculative-load-hardening*

Diff Detail

Event Timeline

zbrid created this revision.Mar 4 2020, 3:00 PM
zbrid retitled this revision from [x86][slh] NFC: Rm redundant liveness check to [x86][slh][NFC] Rm redundant liveness check.Mar 5 2020, 1:15 PM
This revision is now accepted and ready to land.Mar 5 2020, 4:47 PM
This revision was automatically updated to reflect the committed changes.