Page MenuHomePhabricator

[MachineVerifier] Remove placement rule exception for debug entry values
ClosedPublic

Authored by vsk on Mar 3 2020, 12:24 PM.

Details

Summary

There should not be an exception allowing debug entry values to be
placed after a terminator.

Depends on D75548.

rdar://59859175

Diff Detail

Event Timeline

vsk created this revision.Mar 3 2020, 12:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2020, 12:24 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
djtodoro accepted this revision.Mar 3 2020, 12:38 PM

LGTM

llvm/lib/CodeGen/MachineVerifier.cpp
841

I was wondering if we updated this as well, excellent!

llvm/test/DebugInfo/MIR/AArch64/no-dbg-value-after-terminator.mir
21

Nice test! It is well reduced.

This revision is now accepted and ready to land.Mar 3 2020, 12:38 PM
This revision was automatically updated to reflect the committed changes.