This is an archive of the discontinued LLVM Phabricator instance.

Change CMake so that we only look for Z3 when LLVM_ENABLE_Z3_SOLVER is enabled
ClosedPublic

Authored by hcorion on Mar 3 2020, 10:28 AM.

Diff Detail

Event Timeline

hcorion created this revision.Mar 3 2020, 10:28 AM

Seems like the previous behavior was to try to find a compatible Z3 and use it even if the user didn't opt-in.
I am not sure if there was a strong use case for this, I rather have something like this more explicitly configured.

So LGTM, but the original author of this configuration (or someone else knowledgeable about LLVM uses of Z3) should also chime in.

mikhail.ramalho accepted this revision.Jun 5 2020, 10:03 AM

LGTM.

Do you have permission to push the patch? Otherwise, I can push it.

This revision is now accepted and ready to land.Jun 5 2020, 10:03 AM

AFAIK I don't have push permissions, thanks I appreciate that.

This revision was automatically updated to reflect the committed changes.