Split findUnwindSectionByPhdr by targets--arm eabi and others.

[saugustine]

Summary

Hopefully NFC, but this is trickier to determine.

[saugustine]

Fix small clang-tidy complaint.

[saugustine]

The clang-tidy and clang-format failures are all pre-existing, but that is hard to tell from the refactor.

I have fixed the "auto cbdata" -> "auto *cbdata", complaint, because that seems likely to cause confusion to the future readers. But the rest is a rabbit hole of old code that existed long before the style guide, and cleaning that up will make this code not match the surrounding file.

[MaskRay]

The title is

Split findUnwindSectionByPhdr by targets--arm eabi and others.

However, the patch just changes 2 auto to auto *? Is there any missing change in this patch?

The two auto * should be safe.

[saugustine]

Update for clang tidy.

libunwind/src/AddressSpace.hpp

struct _LIBUNWIND_HIDDEN dl_iterate_cb_data {
   UnwindInfoSections *sects;
   uintptr_t targetAddr;
 };
 #endif  // defined(_LIBUNWIND_ARM_EHABI) || defined(_LIBUNWIND_SUPPORT_DWARF_UNWIND)
 
 #if defined(_LIBUNWIND_ARM_EHABI)
 
 static int findUnwindSectionByPhdr(struct dl_phdr_info *pinfo, size_t, void *data) {
-  auto cbdata = static_cast<dl_iterate_cb_data *>(data);
+  auto *cbdata = static_cast<dl_iterate_cb_data *>(data);
   bool found_obj = false;
   bool found_hdr = false;
 
   assert(cbdata);
   assert(cbdata->sects);
 
   if (cbdata->targetAddr < pinfo->dlpi_addr) {
     return false;
for (Elf_Half i = 0; i < pinfo->dlpi_phnum; i++) {
     }
   }
   return found_obj && found_hdr;
 }
 
 #else // defined(_LIBUNWIND_ARM_EHABI)
 
 static int findUnwindSectionByPhdr(struct dl_phdr_info *pinfo, size_t, void *data) {
-  auto cbdata = static_cast<dl_iterate_cb_data *>(data);
+  auto *cbdata = static_cast<dl_iterate_cb_data *>(data);
   bool found_obj = false;
   bool found_hdr = false;
 
   assert(cbdata);
   assert(cbdata->sects);
 
   if (cbdata->targetAddr < pinfo->dlpi_addr) {
     return false;