Page MenuHomePhabricator

Split findUnwindSectionByPhdr by targets--arm eabi and others.

Authored by saugustine on Mar 3 2020, 9:59 AM.



Hopefully NFC, but this is trickier to determine.

Diff Detail

Event Timeline

saugustine created this revision.Mar 3 2020, 9:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2020, 9:59 AM

Fix small clang-tidy complaint.

The clang-tidy and clang-format failures are all pre-existing, but that is hard to tell from the refactor.

I have fixed the "auto cbdata" -> "auto *cbdata", complaint, because that seems likely to cause confusion to the future readers. But the rest is a rabbit hole of old code that existed long before the style guide, and cleaning that up will make this code not match the surrounding file.

The title is

Split findUnwindSectionByPhdr by targets--arm eabi and others.

However, the patch just changes 2 auto to auto *? Is there any missing change in this patch?

The two auto * should be safe.

Update for clang tidy.

saugustine abandoned this revision.Mar 4 2020, 12:45 PM