Page MenuHomePhabricator

[lld][WebAssembly] Handle mixed strong and weak undefined symbols
ClosedPublic

Authored by sbc100 on Feb 27 2020, 5:35 PM.

Details

Summary

When there are both strong and weak references to an undefined
symbol ensure that the strong reference prevails in the output symbol
generating the correct error.

Test case copied from lld/test/ELF/weak-and-strong-undef.s

Diff Detail

Event Timeline

sbc100 created this revision.Feb 27 2020, 5:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2020, 5:35 PM
dschuff accepted this revision.Feb 28 2020, 9:04 AM
dschuff added inline comments.
lld/test/wasm/weak-and-strong-undef.s
3

string->strong

lld/wasm/SymbolTable.cpp
430

symbols->symbol

This revision is now accepted and ready to land.Feb 28 2020, 9:04 AM
This revision was automatically updated to reflect the committed changes.