This is an archive of the discontinued LLVM Phabricator instance.

[FPEnv][ARM] Don't call mutateStrictFPToFP when lowering
ClosedPublic

Authored by john.brawn on Feb 17 2020, 9:33 AM.

Details

Summary

mutateStrictFPToFP can delete the node and replace it with another with the same value which can later cause problems, and returning the result of mutateStrictFPToFP doesn't work because SelectionDAGLegalize expects that the returned value has the same number of results as the original. Instead handle things by doing the mutation manually.

Diff Detail

Event Timeline

john.brawn created this revision.Feb 17 2020, 9:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2020, 9:33 AM
miyuki accepted this revision.Feb 17 2020, 9:45 AM
This revision is now accepted and ready to land.Feb 17 2020, 9:45 AM
This revision was automatically updated to reflect the committed changes.