Page MenuHomePhabricator

[AMDGPU] Use generated RegisterPressureSets enum
ClosedPublic

Authored by rampitec on Feb 15 2020, 10:39 AM.

Diff Detail

Event Timeline

rampitec created this revision.Feb 15 2020, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2020, 10:39 AM
nhaehnle accepted this revision.Feb 16 2020, 3:35 AM

LGTM. I agree with Matt that it would be great not to create those other pressure sets in the first place, possibly by adding some .td file construct to explicitly list the ones that are required. That said, this change is clearly a step in the right direction.

This revision is now accepted and ready to land.Feb 16 2020, 3:35 AM

LGTM. I agree with Matt that it would be great not to create those other pressure sets in the first place, possibly by adding some .td file construct to explicitly list the ones that are required. That said, this change is clearly a step in the right direction.

We need only 2 or maybe 3 of psets, and this makes a lot of sense to add a syntax to explicitly request psets, but even then we need an enum to identify these 2 or 3. I.e. I agree as well, but the change is orthogonal.

This revision was automatically updated to reflect the committed changes.