This is an archive of the discontinued LLVM Phabricator instance.

Don't call computeHostNumPhysicalCores when LLVM_ENABLE_THREADS is off
ClosedPublic

Authored by akhuang on Feb 14 2020, 2:54 PM.

Details

Summary

Fix change from 8404aeb56a73 to avoid calling
computeHostNumPhysicalCores if LLVM_ENABLE_THREADS is off.

Diff Detail

Event Timeline

akhuang created this revision.Feb 14 2020, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2020, 2:54 PM
rnk accepted this revision.Feb 14 2020, 3:07 PM

lgtm

This revision is now accepted and ready to land.Feb 14 2020, 3:07 PM
This revision was automatically updated to reflect the committed changes.
rnk added inline comments.Feb 14 2020, 3:45 PM
llvm/lib/Support/Host.cpp
1329

As we discovered later, this should be spelled LLVM_ENABLE_THREADS != 0, and something needs to be done to fix SupportTests

akhuang reopened this revision.Feb 14 2020, 3:57 PM
This revision is now accepted and ready to land.Feb 14 2020, 3:57 PM
akhuang updated this revision to Diff 244789.Feb 14 2020, 3:58 PM

Fix test and macro spelling

rnk closed this revision.Feb 18 2020, 3:58 PM

lgtm

To be clear, this landed as rGcb36bfa3de3ecba0e30de766999243eb72360533.