This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Add add commit characters to the server capabilities
ClosedPublic

Authored by kbobyrev on Feb 14 2020, 5:09 AM.

Details

Summary

Make it more convinient for the clients to select completion items by
providing a set of default characters (punctuation).

Related issue: https://github.com/clangd/clangd/issues/284

Diff Detail

Unit TestsFailed

Event Timeline

kbobyrev created this revision.Feb 14 2020, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2020, 5:09 AM
sammccall accepted this revision.Feb 18 2020, 7:01 AM
sammccall added inline comments.
clang-tools-extra/clangd/ClangdLSPServer.cpp
562

I think you're missing pipe and single-quote

This revision is now accepted and ready to land.Feb 18 2020, 7:01 AM
kbobyrev updated this revision to Diff 245331.Feb 18 2020, 11:28 PM

Add pipe and single quote to commit characters.

kbobyrev marked an inline comment as done.Feb 18 2020, 11:29 PM
This revision was automatically updated to reflect the committed changes.