Page MenuHomePhabricator

[AMDGPU] Don’t marke the .note section as ALLOC
ClosedPublic

Authored by Flakebi on Feb 14 2020, 3:10 AM.

Details

Summary

Marking a section as ALLOC tells the ELF loader to load the section into memory.
As we do not want to load the notes into VRAM, the flag should not be there.

Diff Detail

Event Timeline

sebastian-ne created this revision.Feb 14 2020, 3:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2020, 3:10 AM
Flakebi commandeered this revision.Feb 17 2020, 1:44 AM
Flakebi added a reviewer: sebastian-ne.
Flakebi updated this revision to Diff 244927.Feb 17 2020, 1:48 AM

Fix test, I hope the existing test suffices.

I thought about adding a test that checks that the code section is the only section with flags != 0
but this won’t hold when a data section or others get used.

This revision is now accepted and ready to land.Feb 19 2020, 4:10 AM
This revision was automatically updated to reflect the committed changes.