Page MenuHomePhabricator

[VE] Support for PIC (global data and calls)
ClosedPublic

Authored by simoll on Feb 13 2020, 2:09 AM.

Details

Summary

Support for PIC with tests for global variables and function calls.

Diff Detail

Event Timeline

simoll created this revision.Feb 13 2020, 2:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2020, 2:09 AM
arsenm added inline comments.Feb 13 2020, 8:07 AM
llvm/lib/Target/VE/VEAsmPrinter.cpp
210

Typo supporeted repeated a few times

llvm/lib/Target/VE/VEISelDAGToDAG.cpp
135

s/unsigned/Register

llvm/lib/Target/VE/VEISelLowering.cpp
698–700

use the dyn_cast value instead of checking and dyn_casting again

llvm/lib/Target/VE/VEInstrInfo.h
79

s/unsigned/Register

simoll updated this revision to Diff 244442.Feb 13 2020, 8:32 AM
simoll marked 4 inline comments as done.
  • rebased
  • addressed comments
simoll updated this revision to Diff 244446.Feb 13 2020, 8:41 AM

unsigned -> Register

arsenm accepted this revision.Feb 13 2020, 5:04 PM
arsenm added inline comments.
llvm/lib/Target/VE/VEAsmPrinter.cpp
153

Missing line

This revision is now accepted and ready to land.Feb 13 2020, 5:04 PM
simoll planned changes to this revision.Feb 14 2020, 12:43 AM
simoll marked an inline comment as done.
  • API change EmitInstruction -> emitInstruction
  • following coding standard for all new functions (EmitSIC -> emitSIC)
simoll updated this revision to Diff 244579.Feb 14 2020, 12:49 AM
  • rebased
  • coding standard
  • newline
This revision is now accepted and ready to land.Feb 14 2020, 12:49 AM
This revision was automatically updated to reflect the committed changes.