This is an archive of the discontinued LLVM Phabricator instance.

Differential D74523

Explicitly state the output file.
ClosedPublic

Authored by saugustine on Feb 12 2020, 9:25 PM.

Details

Reviewers
• espindola
mehdi_amini
Commits
rGa7ecf4c324eb: Explicitly state the output file.
Summary

Even though this test is a check for failure, lld still attempts
to open the final output file, which fails when the default "a.out"
file is used and the current directory is read-only. Specifying an
output file works around this problem.

Diff Detail

Event Timeline

saugustine created this revision.Feb 12 2020, 9:25 PM
Herald added a reviewer: • espindola. · View Herald TranscriptFeb 12 2020, 9:25 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, MaskRay, emaste. · View Herald Transcript
Harbormaster completed remote builds in B46378: Diff 244330.Feb 12 2020, 9:28 PM
mehdi_amini accepted this revision.Feb 12 2020, 9:29 PM
mehdi_amini added a subscriber: mehdi_amini.

Writing to a temp file seems like generally the right pattern, if only because a concurrent test could race on the file creation/deletion.

This revision is now accepted and ready to land.Feb 12 2020, 9:29 PM
Closed by commit rGa7ecf4c324eb: Explicitly state the output file. (authored by saugustine). · Explain WhyFeb 12 2020, 9:37 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added inline comments.Feb 12 2020, 9:37 PM
lld/test/ELF/linkerscript/insert-not-exist.test
3

-o /dev/null

Revision Contents

PathSize
lld/
test/
ELF/
linkerscript/
2 lines

Diff 244330

lld/test/ELF/linkerscript/insert-not-exist.test

# REQUIRES: x86 # REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64 %p/Inputs/insert-after.s -o %t.o # RUN: llvm-mc -filetype=obj -triple=x86_64 %p/Inputs/insert-after.s -o %t.o
# RUN: not ld.lld -T %s %t.o 2>&1 | FileCheck %s # RUN: not ld.lld -T %s %t.o -o %t.out 2>&1 | FileCheck %s
MaskRayUnsubmitted
Not Done
ReplyInline Actions

-o /dev/null

MaskRay: `-o /dev/null`
# CHECK: error: unable to insert .foo.data after .not_exist # CHECK: error: unable to insert .foo.data after .not_exist
# CHECK: error: unable to insert .foo.text before .not_exist # CHECK: error: unable to insert .foo.text before .not_exist
SECTIONS { .foo.data : {} } INSERT AFTER .not_exist; SECTIONS { .foo.data : {} } INSERT AFTER .not_exist;
SECTIONS { .foo.text : {} } INSERT BEFORE .not_exist; SECTIONS { .foo.text : {} } INSERT BEFORE .not_exist;