This is an archive of the discontinued LLVM Phabricator instance.

Differential D74487

Make fiber support in thread sanitizer dynamic linkable
ClosedPublic

Authored by protze.joachim on Feb 12 2020, 8:04 AM.

Details

Reviewers
yuri
dvyukov
jdoerfert
lebedev.ri
Commits
rG31c85ca06d73: [compiler-rt][tsan] Make fiber support in thread sanitizer dynamic linkable
Summary

This patch will allow dynamic libraries to call into the fiber support functions introduced in
https://reviews.llvm.org/D54889

I will use these functions in openmp/tools/archer/ompt-tsan.cpp to handle OpenMP tasks as fibers.
The libarcher.so library built from this file is loaded dynamically by the OpenMP runtime.

Diff Detail

Event Timeline

protze.joachim created this revision.Feb 12 2020, 8:04 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptFeb 12 2020, 8:04 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
jdoerfert added a reviewer: lebedev.ri.Feb 15 2020, 8:13 PM

This looks trivial but I can't really tell. Is there any downside to doing this?

dvyukov accepted this revision.Feb 16 2020, 12:41 AM

No downsides. All public APIs should be here.

This revision is now accepted and ready to land.Feb 16 2020, 12:41 AM
Closed by commit rG31c85ca06d73: [compiler-rt][tsan] Make fiber support in thread sanitizer dynamic linkable (authored by protze.joachim). · Explain WhyMar 11 2020, 6:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
lib/
tsan/
rtl/
5 lines

Diff 249605

compiler-rt/lib/tsan/rtl/tsan.syms.extra

Show All 13 Lines
__tsan_mutex_pre_lock __tsan_mutex_pre_lock
__tsan_mutex_post_lock __tsan_mutex_post_lock
__tsan_mutex_pre_unlock __tsan_mutex_pre_unlock
__tsan_mutex_post_unlock __tsan_mutex_post_unlock
__tsan_mutex_pre_signal __tsan_mutex_pre_signal
__tsan_mutex_post_signal __tsan_mutex_post_signal
__tsan_mutex_pre_divert __tsan_mutex_pre_divert
__tsan_mutex_post_divert __tsan_mutex_post_divert
__tsan_get_current_fiber
__tsan_create_fiber
__tsan_destroy_fiber
__tsan_switch_to_fiber
__tsan_set_fiber_name
__ubsan_* __ubsan_*
Annotate* Annotate*
WTFAnnotate* WTFAnnotate*
RunningOnValgrind RunningOnValgrind
ValgrindSlowdown ValgrindSlowdown