Page MenuHomePhabricator

Make fiber support in thread sanitizer dynamic linkable
ClosedPublic

Authored by protze.joachim on Feb 12 2020, 8:04 AM.

Details

Summary

This patch will allow dynamic libraries to call into the fiber support functions introduced in
https://reviews.llvm.org/D54889

I will use these functions in openmp/tools/archer/ompt-tsan.cpp to handle OpenMP tasks as fibers.
The libarcher.so library built from this file is loaded dynamically by the OpenMP runtime.

Diff Detail

Event Timeline

protze.joachim created this revision.Feb 12 2020, 8:04 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript

This looks trivial but I can't really tell. Is there any downside to doing this?

dvyukov accepted this revision.Feb 16 2020, 12:41 AM

No downsides. All public APIs should be here.

This revision is now accepted and ready to land.Feb 16 2020, 12:41 AM
This revision was automatically updated to reflect the committed changes.