This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Use conditions directly in division expansion
ClosedPublic

Authored by arsenm on Feb 11 2020, 12:54 PM.

Details

Summary

This was creating a select on true/false values, and then comparing
that later. This produced more work for later combines, which can be
avoided by just using the boolean values. This was copied from the
original DAG expansion, which also has the same problem. This doesn't
have a observable change using SelectionDAG, but since GlobalISel is
missing these optimizations, the final code was noticeably longer.

Diff Detail

Event Timeline

arsenm created this revision.Feb 11 2020, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2020, 12:54 PM
rampitec accepted this revision.Feb 11 2020, 1:03 PM
This revision is now accepted and ready to land.Feb 11 2020, 1:03 PM