Page MenuHomePhabricator

[Go] Remove go bindings test as it depends on llvm-go
AbandonedPublic

Authored by JDevlieghere on Feb 11 2020, 11:29 AM.

Details

Reviewers
echristo
pcc
Summary

We removed llgo from the monorepo so the llvm-go binary will no longer be available. This removes the one test for the Go bindings that relies on it. I didn't remove the bindings themselves, although I don't think they should be in tree without a test.

Diff Detail

Event Timeline

JDevlieghere created this revision.Feb 11 2020, 11:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2020, 11:29 AM
Herald added a subscriber: mgorny. · View Herald Transcript
pcc requested changes to this revision.Feb 11 2020, 11:39 AM

We should bring back llvm-go instead. That program doesn't depend on llgo, it's mostly a helper for building the Go bindings.

This revision now requires changes to proceed.Feb 11 2020, 11:39 AM
JDevlieghere abandoned this revision.Feb 13 2020, 8:51 AM