This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Follow up fix for the refactoring in https://reviews.llvm.org/D74137.
ClosedPublic

Authored by Dor1s on Feb 10 2020, 10:21 AM.

Details

Summary

The refactoring has caused a failure in
http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/29265

The idea of failing the symbolization when the symbolizer bufer is too small
was incorrect. The symbolizer can be invoked for other frames that may fit into
the buffer and get symbolized.

Diff Detail

Event Timeline

Dor1s created this revision.Feb 10 2020, 10:21 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 10 2020, 10:21 AM
Herald added subscribers: llvm-commits, Restricted Project, dberris. · View Herald Transcript
Dor1s accepted this revision.Feb 10 2020, 10:22 AM

Self-approval for a quick fix (reverting two lines in https://reviews.llvm.org/D74137).

This revision is now accepted and ready to land.Feb 10 2020, 10:22 AM
This revision was automatically updated to reflect the committed changes.