This is an archive of the discontinued LLVM Phabricator instance.

Differential D74244

[lldb] Delete register info definitions in the x86_64 ABI classes
ClosedPublic

Authored by labath on Feb 7 2020, 11:12 AM.

Details

Reviewers
JDevlieghere
jasonmolenda
Commits
rG07355c1c08be: [lldb] Delete register info definitions in the x86_64 ABI classes
Summary

These definitions are used to "augment" information received from the remote
target with eh/debug frame and "generic" register numbers.

Besides being verbose, this information was also incomplete (new registers like
xmm16-31 were missing) and sometimes even downright wrong (ymm register
numbers).

Most of this information is available via llvm's MCRegisterInfo. This patch
creates a new class, MCBasedABI, which retrieves the eh and debug frame register
numbers this way. The tricky part here is that the llvm class uses all-caps
register names, whereas lldb register are lowercase, and sometimes called
slightly differently. Therefore this class introduces some hooks to allow a
subclass to customize the MC lookup. The subclass also needs to suply the
"generic" register numbers, as this is an lldb invention.

This patch ports the x86_64 ABI classes to use the new register info mechanism.
It also creates a new "ABIx86_64" class which can be used to house code common
to x86_64 both ABIs. Right now, this just consists of a single function, but
there are plenty of other things that could be moved here too.

Diff Detail

Event Timeline

labath created this revision.Feb 7 2020, 11:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2020, 11:12 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B45964: Diff 243245.Feb 7 2020, 11:12 AM
labath added a parent revision: D74243: [lldb] Introduce "RegInfoBasedABI".Feb 7 2020, 11:13 AM
tatyana-krasnukha added a subscriber: tatyana-krasnukha.Feb 10 2020, 4:23 AM
tatyana-krasnukha added inline comments.
lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp
938

Typo? It should be uppercase, I think.

jasonmolenda accepted this revision.Feb 10 2020, 2:24 PM

Nice elimination of duplication.

lldb/source/Target/ABI.cpp
249

Would it be simpler to assign these to LLDB_INVALID_REGNUM at the beginning, instead of -1 and setting it later?

267

will to_integer bit work with an all-letter reg like cpsr?

This revision is now accepted and ready to land.Feb 10 2020, 2:24 PM
labath marked 6 inline comments as done.Feb 14 2020, 4:43 AM
labath added inline comments.
lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp
938

Thanks for catching that. After some consideration, I've decided it would be less confusing if this function (and GetMCName) worked on lowercase register names like everything else lldb. In the new version of this patch I've moved the uppercase transformation closer to the point where we interface with the MC layer.

lldb/source/Target/ABI.cpp
249

Not really, because the MC interface uses -1 to denote registers which don't have a dwarf number. (In fact some of the things in the MC list are not even really registers, but more like combinations of registers that are sometimes handy when grouped (Q0_Q1, etc.)

267

We didn't need this functionality yet because we weren't renaming any singular registers, but I've now added code to handle this too.

labath updated this revision to Diff 244624.Feb 14 2020, 4:44 AM
labath marked 3 inline comments as done.
  • make functions work on lowercase names
  • handle singular registers in the remapping function
Harbormaster completed remote builds in B46494: Diff 244624.Feb 14 2020, 4:45 AM
Closed by commit rG07355c1c08be: [lldb] Delete register info definitions in the x86_64 ABI classes (authored by labath). · Explain WhyFeb 17 2020, 5:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
include/
lldb/
Target/
22 lines
source/
Plugins/
ABI/
X86/
11 lines
169 lines
11 lines
993 lines
26 lines
Target/
38 lines
unittests/
Target/
25 lines
1 line

Diff 243245

lldb/include/lldb/Target/ABI.h

Show First 20 Lines • Show All 157 Lines • ▼ Show 20 Lines
protected: protected:
using ABI::ABI; using ABI::ABI;
bool GetRegisterInfoByName(ConstString name, RegisterInfo &info); bool GetRegisterInfoByName(ConstString name, RegisterInfo &info);
virtual const RegisterInfo *GetRegisterInfoArray(uint32_t &count) = 0; virtual const RegisterInfo *GetRegisterInfoArray(uint32_t &count) = 0;
}; };
class MCBasedABI : public ABI {
public:
void AugmentRegisterInfo(RegisterInfo &info) override;
/// If the register name is of the form "<from_prefix><number>" then change
/// the name to "<to_prefix><number>". Otherwise, leave the name unchanged.
static void MapName(std::string &reg, llvm::StringRef from_prefix,
llvm::StringRef to_prefix);
protected:
using ABI::ABI;
/// Return eh_frame and dwarf numbers for the given register.
virtual std::pair<uint32_t, uint32_t> GetEHAndDWARFNums(llvm::StringRef reg);
/// Return the generic number of the given register.
virtual uint32_t GetGenericNum(llvm::StringRef reg) = 0;
/// For the given (capitalized) lldb register name, return the name of this
/// register in the MCRegisterInfo struct.
virtual std::string GetMCName(std::string reg) { return reg; }
};
} // namespace lldb_private } // namespace lldb_private
#endif // liblldb_ABI_h_ #endif // liblldb_ABI_h_

lldb/source/Plugins/ABI/X86/ABISysV_x86_64.h

//===-- ABISysV_x86_64.h ----------------------------------------*- C++ -*-===// //===-- ABISysV_x86_64.h ----------------------------------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef liblldb_ABISysV_x86_64_h_ #ifndef liblldb_ABISysV_x86_64_h_
#define liblldb_ABISysV_x86_64_h_ #define liblldb_ABISysV_x86_64_h_
#include "lldb/Target/ABI.h" #include "Plugins/ABI/X86/ABIx86_64.h"
#include "lldb/lldb-private.h"
class ABISysV_x86_64 : public lldb_private::RegInfoBasedABI { class ABISysV_x86_64 : public ABIx86_64 {
public: public:
~ABISysV_x86_64() override = default; ~ABISysV_x86_64() override = default;
size_t GetRedZoneSize() const override; size_t GetRedZoneSize() const override;
bool PrepareTrivialCall(lldb_private::Thread &thread, lldb::addr_t sp, bool PrepareTrivialCall(lldb_private::Thread &thread, lldb::addr_t sp,
lldb::addr_t functionAddress, lldb::addr_t functionAddress,
lldb::addr_t returnAddress, lldb::addr_t returnAddress,
Show All 38 Linespublic:
} }
bool CodeAddressIsValid(lldb::addr_t pc) override { bool CodeAddressIsValid(lldb::addr_t pc) override {
// We have a 64 bit address space, so anything is valid as opcodes // We have a 64 bit address space, so anything is valid as opcodes
// aren't fixed width... // aren't fixed width...
return true; return true;
} }
const lldb_private::RegisterInfo *
GetRegisterInfoArray(uint32_t &count) override;
bool GetPointerReturnRegister(const char *&name) override; bool GetPointerReturnRegister(const char *&name) override;
// Static Functions // Static Functions
static void Initialize(); static void Initialize();
static void Terminate(); static void Terminate();
Show All 10 Lines
protected: protected:
void CreateRegisterMapIfNeeded(); void CreateRegisterMapIfNeeded();
lldb::ValueObjectSP lldb::ValueObjectSP
GetReturnValueObjectSimple(lldb_private::Thread &thread, GetReturnValueObjectSimple(lldb_private::Thread &thread,
lldb_private::CompilerType &ast_type) const; lldb_private::CompilerType &ast_type) const;
bool RegisterIsCalleeSaved(const lldb_private::RegisterInfo *reg_info); bool RegisterIsCalleeSaved(const lldb_private::RegisterInfo *reg_info);
uint32_t GetGenericNum(llvm::StringRef reg) override;
private: private:
using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance instead. using ABIx86_64::ABIx86_64; // Call CreateInstance instead.
}; };
#endif // liblldb_ABISysV_x86_64_h_ #endif // liblldb_ABISysV_x86_64_h_

lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Linesenum dwarf_regnums {
dwarf_r9, dwarf_r9,
dwarf_r10, dwarf_r10,
dwarf_r11, dwarf_r11,
dwarf_r12, dwarf_r12,
dwarf_r13, dwarf_r13,
dwarf_r14, dwarf_r14,
dwarf_r15, dwarf_r15,
dwarf_rip, dwarf_rip,
dwarf_xmm0,
dwarf_xmm1,
dwarf_xmm2,
dwarf_xmm3,
dwarf_xmm4,
dwarf_xmm5,
dwarf_xmm6,
dwarf_xmm7,
dwarf_xmm8,
dwarf_xmm9,
dwarf_xmm10,
dwarf_xmm11,
dwarf_xmm12,
dwarf_xmm13,
dwarf_xmm14,
dwarf_xmm15,
dwarf_stmm0,
dwarf_stmm1,
dwarf_stmm2,
dwarf_stmm3,
dwarf_stmm4,
dwarf_stmm5,
dwarf_stmm6,
dwarf_stmm7,
dwarf_ymm0,
dwarf_ymm1,
dwarf_ymm2,
dwarf_ymm3,
dwarf_ymm4,
dwarf_ymm5,
dwarf_ymm6,
dwarf_ymm7,
dwarf_ymm8,
dwarf_ymm9,
dwarf_ymm10,
dwarf_ymm11,
dwarf_ymm12,
dwarf_ymm13,
dwarf_ymm14,
dwarf_ymm15,
dwarf_bnd0 = 126,
dwarf_bnd1,
dwarf_bnd2,
dwarf_bnd3
}; };
static RegisterInfo g_register_infos[] = {
// clang-format off
// NAME ALT SZ OFF ENCODING FORMAT EH_FRAME DWARF GENERIC LLDB NATIVE
// ======== ======= == === ============= =================== ======================= ===================== =========================== ===================== ======================
{"rax", nullptr, 8, 0, eEncodingUint, eFormatHex, {dwarf_rax, dwarf_rax, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rbx", nullptr, 8, 0, eEncodingUint, eFormatHex, {dwarf_rbx, dwarf_rbx, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rcx", "arg4", 8, 0, eEncodingUint, eFormatHex, {dwarf_rcx, dwarf_rcx, LLDB_REGNUM_GENERIC_ARG4, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rdx", "arg3", 8, 0, eEncodingUint, eFormatHex, {dwarf_rdx, dwarf_rdx, LLDB_REGNUM_GENERIC_ARG3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rsi", "arg2", 8, 0, eEncodingUint, eFormatHex, {dwarf_rsi, dwarf_rsi, LLDB_REGNUM_GENERIC_ARG2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rdi", "arg1", 8, 0, eEncodingUint, eFormatHex, {dwarf_rdi, dwarf_rdi, LLDB_REGNUM_GENERIC_ARG1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rbp", "fp", 8, 0, eEncodingUint, eFormatHex, {dwarf_rbp, dwarf_rbp, LLDB_REGNUM_GENERIC_FP, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rsp", "sp", 8, 0, eEncodingUint, eFormatHex, {dwarf_rsp, dwarf_rsp, LLDB_REGNUM_GENERIC_SP, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"r8", "arg5", 8, 0, eEncodingUint, eFormatHex, {dwarf_r8, dwarf_r8, LLDB_REGNUM_GENERIC_ARG5, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"r9", "arg6", 8, 0, eEncodingUint, eFormatHex, {dwarf_r9, dwarf_r9, LLDB_REGNUM_GENERIC_ARG6, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"r10", nullptr, 8, 0, eEncodingUint, eFormatHex, {dwarf_r10, dwarf_r10, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"r11", nullptr, 8, 0, eEncodingUint, eFormatHex, {dwarf_r11, dwarf_r11, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"r12", nullptr, 8, 0, eEncodingUint, eFormatHex, {dwarf_r12, dwarf_r12, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"r13", nullptr, 8, 0, eEncodingUint, eFormatHex, {dwarf_r13, dwarf_r13, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"r14", nullptr, 8, 0, eEncodingUint, eFormatHex, {dwarf_r14, dwarf_r14, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"r15", nullptr, 8, 0, eEncodingUint, eFormatHex, {dwarf_r15, dwarf_r15, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rip", "pc", 8, 0, eEncodingUint, eFormatHex, {dwarf_rip, dwarf_rip, LLDB_REGNUM_GENERIC_PC, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"rflags", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_REGNUM_GENERIC_FLAGS, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"cs", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ss", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ds", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"es", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"fs", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"gs", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"stmm0", nullptr, 10, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_stmm0, dwarf_stmm0, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"stmm1", nullptr, 10, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_stmm1, dwarf_stmm1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"stmm2", nullptr, 10, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_stmm2, dwarf_stmm2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"stmm3", nullptr, 10, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_stmm3, dwarf_stmm3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"stmm4", nullptr, 10, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_stmm4, dwarf_stmm4, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"stmm5", nullptr, 10, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_stmm5, dwarf_stmm5, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"stmm6", nullptr, 10, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_stmm6, dwarf_stmm6, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"stmm7", nullptr, 10, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_stmm7, dwarf_stmm7, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"fctrl", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"fstat", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ftag", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"fiseg", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"fioff", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"foseg", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"fooff", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"fop", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm0", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm0, dwarf_xmm0, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm1", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm1, dwarf_xmm1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm2", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm2, dwarf_xmm2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm3", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm3, dwarf_xmm3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm4", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm4, dwarf_xmm4, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm5", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm5, dwarf_xmm5, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm6", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm6, dwarf_xmm6, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm7", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm7, dwarf_xmm7, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm8", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm8, dwarf_xmm8, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm9", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm9, dwarf_xmm9, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm10", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm10, dwarf_xmm10, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm11", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm11, dwarf_xmm11, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm12", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm12, dwarf_xmm12, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm13", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm13, dwarf_xmm13, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm14", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm14, dwarf_xmm14, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"xmm15", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_xmm15, dwarf_xmm15, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"mxcsr", nullptr, 4, 0, eEncodingUint, eFormatHex, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm0", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm0, dwarf_ymm0, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm1", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm1, dwarf_ymm1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm2", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm2, dwarf_ymm2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm3", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm3, dwarf_ymm3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm4", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm4, dwarf_ymm4, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm5", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm5, dwarf_ymm5, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm6", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm6, dwarf_ymm6, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm7", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm7, dwarf_ymm7, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm8", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm8, dwarf_ymm8, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm9", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm9, dwarf_ymm9, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm10", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm10, dwarf_ymm10, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm11", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm11, dwarf_ymm11, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm12", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm12, dwarf_ymm12, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm13", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm13, dwarf_ymm13, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm14", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm14, dwarf_ymm14, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"ymm15", nullptr, 32, 0, eEncodingVector, eFormatVectorOfUInt8, {dwarf_ymm15, dwarf_ymm15, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"bnd0", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt64, {dwarf_bnd0, dwarf_bnd0, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"bnd1", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt64, {dwarf_bnd1, dwarf_bnd1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"bnd2", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt64, {dwarf_bnd2, dwarf_bnd2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"bnd3", nullptr, 16, 0, eEncodingVector, eFormatVectorOfUInt64, {dwarf_bnd3, dwarf_bnd3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"bndcfgu", nullptr, 8, 0, eEncodingVector, eFormatVectorOfUInt8, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
{"bndstatus",nullptr, 8, 0, eEncodingVector, eFormatVectorOfUInt8, {LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM}, nullptr, nullptr, nullptr, 0},
// clang-format on
};
static const uint32_t k_num_register_infos =
llvm::array_lengthof(g_register_infos);
static bool g_register_info_names_constified = false;
const lldb_private::RegisterInfo *
ABISysV_x86_64::GetRegisterInfoArray(uint32_t &count) {
// Make the C-string names and alt_names for the register infos into const
// C-string values by having the ConstString unique the names in the global
// constant C-string pool.
if (!g_register_info_names_constified) {
g_register_info_names_constified = true;
for (uint32_t i = 0; i < k_num_register_infos; ++i) {
if (g_register_infos[i].name)
g_register_infos[i].name =
ConstString(g_register_infos[i].name).GetCString();
if (g_register_infos[i].alt_name)
g_register_infos[i].alt_name =
ConstString(g_register_infos[i].alt_name).GetCString();
}
}
count = k_num_register_infos;
return g_register_infos;
}
bool ABISysV_x86_64::GetPointerReturnRegister(const char *&name) { bool ABISysV_x86_64::GetPointerReturnRegister(const char *&name) {
name = "rax"; name = "rax";
return true; return true;
} }
size_t ABISysV_x86_64::GetRedZoneSize() const { return 128; } size_t ABISysV_x86_64::GetRedZoneSize() const { return 128; }
// Static Functions // Static Functions
▲ Show 20 Lines • Show All 853 Lines • ▼ Show 20 Linesbool ABISysV_x86_64::RegisterIsCalleeSaved(const RegisterInfo *reg_info) {
bool IsCalleeSaved = bool IsCalleeSaved =
llvm::StringSwitch<bool>(Name) llvm::StringSwitch<bool>(Name)
.Cases("r12", "r13", "r14", "r15", "rbp", "ebp", "rbx", "ebx", true) .Cases("r12", "r13", "r14", "r15", "rbp", "ebp", "rbx", "ebx", true)
.Cases("rip", "eip", "rsp", "esp", "sp", "fp", "pc", true) .Cases("rip", "eip", "rsp", "esp", "sp", "fp", "pc", true)
.Default(false); .Default(false);
return IsCalleeSaved; return IsCalleeSaved;
} }
uint32_t ABISysV_x86_64::GetGenericNum(llvm::StringRef name) {
return llvm::StringSwitch<uint32_t>(name)
.Case("RIP", LLDB_REGNUM_GENERIC_PC)
.Case("RSP", LLDB_REGNUM_GENERIC_SP)
.Case("RBP", LLDB_REGNUM_GENERIC_FP)
.Case("RFLAGS", LLDB_REGNUM_GENERIC_FLAGS)
.Case("RDI", LLDB_REGNUM_GENERIC_ARG1)
.Case("RSI", LLDB_REGNUM_GENERIC_ARG2)
.Case("RDX", LLDB_REGNUM_GENERIC_ARG3)
.Case("RCX", LLDB_REGNUM_GENERIC_ARG4)
.Case("R8", LLDB_REGNUM_GENERIC_ARG5)
.Case("r9", LLDB_REGNUM_GENERIC_ARG6)
tatyana-krasnukhaUnsubmitted
Done
ReplyInline Actions

Typo? It should be uppercase, I think.

tatyana-krasnukha: Typo? It should be uppercase, I think.
labathAuthorUnsubmitted
Done
ReplyInline Actions

Thanks for catching that. After some consideration, I've decided it would be less confusing if this function (and GetMCName) worked on lowercase register names like everything else lldb. In the new version of this patch I've moved the uppercase transformation closer to the point where we interface with the MC layer.

labath: Thanks for catching that. After some consideration, I've decided it would be less confusing if…
.Default(LLDB_INVALID_REGNUM);
}
void ABISysV_x86_64::Initialize() { void ABISysV_x86_64::Initialize() {
PluginManager::RegisterPlugin( PluginManager::RegisterPlugin(
GetPluginNameStatic(), "System V ABI for x86_64 targets", CreateInstance); GetPluginNameStatic(), "System V ABI for x86_64 targets", CreateInstance);
} }
void ABISysV_x86_64::Terminate() { void ABISysV_x86_64::Terminate() {
PluginManager::UnregisterPlugin(CreateInstance); PluginManager::UnregisterPlugin(CreateInstance);
} }
Show All 13 Lines

lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.h

//===-- ABIWindows_x86_64.h ----------------------------------------*- C++ -*-===// //===-- ABIWindows_x86_64.h ----------------------------------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef liblldb_ABIWindows_x86_64_h_ #ifndef liblldb_ABIWindows_x86_64_h_
#define liblldb_ABIWindows_x86_64_h_ #define liblldb_ABIWindows_x86_64_h_
#include "lldb/Target/ABI.h" #include "Plugins/ABI/X86/ABIx86_64.h"
#include "lldb/lldb-private.h"
class ABIWindows_x86_64 : public lldb_private::RegInfoBasedABI { class ABIWindows_x86_64 : public ABIx86_64 {
public: public:
~ABIWindows_x86_64() override = default; ~ABIWindows_x86_64() override = default;
size_t GetRedZoneSize() const override; size_t GetRedZoneSize() const override;
bool PrepareTrivialCall(lldb_private::Thread &thread, lldb::addr_t sp, bool PrepareTrivialCall(lldb_private::Thread &thread, lldb::addr_t sp,
lldb::addr_t functionAddress, lldb::addr_t functionAddress,
lldb::addr_t returnAddress, lldb::addr_t returnAddress,
Show All 27 Linespublic:
} }
bool CodeAddressIsValid(lldb::addr_t pc) override { bool CodeAddressIsValid(lldb::addr_t pc) override {
// We have a 64 bit address space, so anything is valid as opcodes // We have a 64 bit address space, so anything is valid as opcodes
// aren't fixed width... // aren't fixed width...
return true; return true;
} }
const lldb_private::RegisterInfo *
GetRegisterInfoArray(uint32_t &count) override;
bool GetPointerReturnRegister(const char *&name) override; bool GetPointerReturnRegister(const char *&name) override;
//------------------------------------------------------------------ //------------------------------------------------------------------
// Static Functions // Static Functions
//------------------------------------------------------------------ //------------------------------------------------------------------
static void Initialize(); static void Initialize();
Show All 14 Lines
protected: protected:
void CreateRegisterMapIfNeeded(); void CreateRegisterMapIfNeeded();
lldb::ValueObjectSP lldb::ValueObjectSP
GetReturnValueObjectSimple(lldb_private::Thread &thread, GetReturnValueObjectSimple(lldb_private::Thread &thread,
lldb_private::CompilerType &ast_type) const; lldb_private::CompilerType &ast_type) const;
bool RegisterIsCalleeSaved(const lldb_private::RegisterInfo *reg_info); bool RegisterIsCalleeSaved(const lldb_private::RegisterInfo *reg_info);
uint32_t GetGenericNum(llvm::StringRef reg) override;
private: private:
using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance instead. using ABIx86_64::ABIx86_64; // Call CreateInstance instead.
}; };
#endif // liblldb_ABISysV_x86_64_h_ #endif // liblldb_ABISysV_x86_64_h_

lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Linesenum dwarf_regnums {
dwarf_ymm14, dwarf_ymm14,
dwarf_ymm15, dwarf_ymm15,
dwarf_bnd0 = 126, dwarf_bnd0 = 126,
dwarf_bnd1, dwarf_bnd1,
dwarf_bnd2, dwarf_bnd2,
dwarf_bnd3 dwarf_bnd3
}; };
static RegisterInfo g_register_infos[] = {
// NAME ALT SZ OFF ENCODING FORMAT EH_FRAME
// DWARF GENERIC PROCESS PLUGIN
// LLDB NATIVE
// ======== ======= == === ============= ===================
// ======================= =====================
// =========================== ===================== ======================
{"rax",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rax, dwarf_rax, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rbx",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rbx, dwarf_rbx, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rcx",
"arg1",
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rcx, dwarf_rcx, LLDB_REGNUM_GENERIC_ARG1, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rdx",
"arg2",
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rdx, dwarf_rdx, LLDB_REGNUM_GENERIC_ARG2, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rsi",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rsi, dwarf_rsi, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rdi",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rdi, dwarf_rdi, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rbp",
"fp",
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rbp, dwarf_rbp, LLDB_REGNUM_GENERIC_FP, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rsp",
"sp",
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rsp, dwarf_rsp, LLDB_REGNUM_GENERIC_SP, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"r8",
"arg3",
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_r8, dwarf_r8, LLDB_REGNUM_GENERIC_ARG3, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"r9",
"arg4",
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_r9, dwarf_r9, LLDB_REGNUM_GENERIC_ARG4, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"r10",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_r10, dwarf_r10, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"r11",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_r11, dwarf_r11, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"r12",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_r12, dwarf_r12, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"r13",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_r13, dwarf_r13, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"r14",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_r14, dwarf_r14, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"r15",
nullptr,
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_r15, dwarf_r15, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rip",
"pc",
8,
0,
eEncodingUint,
eFormatHex,
{dwarf_rip, dwarf_rip, LLDB_REGNUM_GENERIC_PC, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"rflags",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_REGNUM_GENERIC_FLAGS,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"cs",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ss",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ds",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"es",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"fs",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"gs",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"stmm0",
nullptr,
10,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_stmm0, dwarf_stmm0, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"stmm1",
nullptr,
10,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_stmm1, dwarf_stmm1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"stmm2",
nullptr,
10,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_stmm2, dwarf_stmm2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"stmm3",
nullptr,
10,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_stmm3, dwarf_stmm3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"stmm4",
nullptr,
10,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_stmm4, dwarf_stmm4, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"stmm5",
nullptr,
10,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_stmm5, dwarf_stmm5, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"stmm6",
nullptr,
10,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_stmm6, dwarf_stmm6, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"stmm7",
nullptr,
10,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_stmm7, dwarf_stmm7, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"fctrl",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"fstat",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ftag",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"fiseg",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"fioff",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"foseg",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"fooff",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"fop",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm0",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm0, dwarf_xmm0, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm1",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm1, dwarf_xmm1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm2",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm2, dwarf_xmm2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm3",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm3, dwarf_xmm3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm4",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm4, dwarf_xmm4, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm5",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm5, dwarf_xmm5, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm6",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm6, dwarf_xmm6, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm7",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm7, dwarf_xmm7, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm8",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm8, dwarf_xmm8, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm9",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm9, dwarf_xmm9, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm10",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm10, dwarf_xmm10, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm11",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm11, dwarf_xmm11, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm12",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm12, dwarf_xmm12, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm13",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm13, dwarf_xmm13, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm14",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm14, dwarf_xmm14, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"xmm15",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_xmm15, dwarf_xmm15, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"mxcsr",
nullptr,
4,
0,
eEncodingUint,
eFormatHex,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm0",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm0, dwarf_ymm0, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm1",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm1, dwarf_ymm1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm2",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm2, dwarf_ymm2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm3",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm3, dwarf_ymm3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm4",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm4, dwarf_ymm4, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm5",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm5, dwarf_ymm5, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm6",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm6, dwarf_ymm6, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm7",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm7, dwarf_ymm7, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm8",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm8, dwarf_ymm8, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm9",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm9, dwarf_ymm9, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm10",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm10, dwarf_ymm10, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm11",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm11, dwarf_ymm11, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm12",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm12, dwarf_ymm12, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm13",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm13, dwarf_ymm13, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm14",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm14, dwarf_ymm14, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"ymm15",
nullptr,
32,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{dwarf_ymm15, dwarf_ymm15, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"bnd0",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt64,
{dwarf_bnd0, dwarf_bnd0, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"bnd1",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt64,
{dwarf_bnd1, dwarf_bnd1, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"bnd2",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt64,
{dwarf_bnd2, dwarf_bnd2, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"bnd3",
nullptr,
16,
0,
eEncodingVector,
eFormatVectorOfUInt64,
{dwarf_bnd3, dwarf_bnd3, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"bndcfgu",
nullptr,
8,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0},
{"bndstatus",
nullptr,
8,
0,
eEncodingVector,
eFormatVectorOfUInt8,
{LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM,
LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM},
nullptr,
nullptr,
nullptr,
0}};
static const uint32_t k_num_register_infos =
llvm::array_lengthof(g_register_infos);
static bool g_register_info_names_constified = false;
const lldb_private::RegisterInfo *
ABIWindows_x86_64::GetRegisterInfoArray(uint32_t &count) {
// Make the C-string names and alt_names for the register infos into const
// C-string values by having the ConstString unique the names in the global
// constant C-string pool.
if (!g_register_info_names_constified) {
g_register_info_names_constified = true;
for (uint32_t i = 0; i < k_num_register_infos; ++i) {
if (g_register_infos[i].name)
g_register_infos[i].name =
ConstString(g_register_infos[i].name).GetCString();
if (g_register_infos[i].alt_name)
g_register_infos[i].alt_name =
ConstString(g_register_infos[i].alt_name).GetCString();
}
}
count = k_num_register_infos;
return g_register_infos;
}
bool ABIWindows_x86_64::GetPointerReturnRegister(const char *&name) { bool ABIWindows_x86_64::GetPointerReturnRegister(const char *&name) {
name = "rax"; name = "rax";
return true; return true;
} }
size_t ABIWindows_x86_64::GetRedZoneSize() const { return 0; } size_t ABIWindows_x86_64::GetRedZoneSize() const { return 0; }
//------------------------------------------------------------------ //------------------------------------------------------------------
▲ Show 20 Lines • Show All 684 Lines • ▼ Show 20 Lines bool IsCalleeSaved =
.Cases("rbx", "ebx", "rbp", "ebp", "rdi", "edi", "rsi", "esi", true) .Cases("rbx", "ebx", "rbp", "ebp", "rdi", "edi", "rsi", "esi", true)
.Cases("rsp", "esp", "r12", "r13", "r14", "r15", "sp", "fp", true) .Cases("rsp", "esp", "r12", "r13", "r14", "r15", "sp", "fp", true)
.Cases("xmm6", "xmm7", "xmm8", "xmm9", "xmm10", "xmm11", "xmm12", .Cases("xmm6", "xmm7", "xmm8", "xmm9", "xmm10", "xmm11", "xmm12",
"xmm13", "xmm14", "xmm15", true) "xmm13", "xmm14", "xmm15", true)
.Default(false); .Default(false);
return IsCalleeSaved; return IsCalleeSaved;
} }
uint32_t ABIWindows_x86_64::GetGenericNum(llvm::StringRef reg) {
return llvm::StringSwitch<uint32_t>(reg)
.Case("RIP", LLDB_REGNUM_GENERIC_PC)
.Case("RSP", LLDB_REGNUM_GENERIC_SP)
.Case("RBP", LLDB_REGNUM_GENERIC_FP)
.Case("RFLAGS", LLDB_REGNUM_GENERIC_FLAGS)
.Case("RCX", LLDB_REGNUM_GENERIC_ARG1)
.Case("RDX", LLDB_REGNUM_GENERIC_ARG2)
.Case("R8", LLDB_REGNUM_GENERIC_ARG3)
.Case("R9", LLDB_REGNUM_GENERIC_ARG4)
.Default(LLDB_INVALID_REGNUM);
}
void ABIWindows_x86_64::Initialize() { void ABIWindows_x86_64::Initialize() {
PluginManager::RegisterPlugin( PluginManager::RegisterPlugin(
GetPluginNameStatic(), "Windows ABI for x86_64 targets", CreateInstance); GetPluginNameStatic(), "Windows ABI for x86_64 targets", CreateInstance);
} }
void ABIWindows_x86_64::Terminate() { void ABIWindows_x86_64::Terminate() {
PluginManager::UnregisterPlugin(CreateInstance); PluginManager::UnregisterPlugin(CreateInstance);
} }
Show All 15 Lines

lldb/source/Plugins/ABI/X86/ABIx86_64.h

  • This file was added.
//===-- ABIx86_64.h ---------------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLDB_PLUGIN_ABI_X86_ABIX86_64_H
#define LLDB_PLUGIN_ABI_X86_ABIX86_64_H
#include "lldb/Target/ABI.h"
#include "lldb/lldb-private.h"
class ABIx86_64 : public lldb_private::MCBasedABI {
protected:
std::string GetMCName(std::string name) override {
MapName(name, "STMM", "ST");
return name;
}
private:
using lldb_private::MCBasedABI::MCBasedABI;
};
#endif // LLDB_PLUGIN_ABI_X86_ABIX86_64_H

lldb/source/Target/ABI.cpp

Show First 20 Lines • Show All 222 Lines • ▼ Show 20 Linesvoid RegInfoBasedABI::AugmentRegisterInfo(RegisterInfo &info) {
if (info.kinds[eRegisterKindEHFrame] == LLDB_INVALID_REGNUM) if (info.kinds[eRegisterKindEHFrame] == LLDB_INVALID_REGNUM)
info.kinds[eRegisterKindEHFrame] = abi_info.kinds[eRegisterKindEHFrame]; info.kinds[eRegisterKindEHFrame] = abi_info.kinds[eRegisterKindEHFrame];
if (info.kinds[eRegisterKindDWARF] == LLDB_INVALID_REGNUM) if (info.kinds[eRegisterKindDWARF] == LLDB_INVALID_REGNUM)
info.kinds[eRegisterKindDWARF] = abi_info.kinds[eRegisterKindDWARF]; info.kinds[eRegisterKindDWARF] = abi_info.kinds[eRegisterKindDWARF];
if (info.kinds[eRegisterKindGeneric] == LLDB_INVALID_REGNUM) if (info.kinds[eRegisterKindGeneric] == LLDB_INVALID_REGNUM)
info.kinds[eRegisterKindGeneric] = abi_info.kinds[eRegisterKindGeneric]; info.kinds[eRegisterKindGeneric] = abi_info.kinds[eRegisterKindGeneric];
} }
void MCBasedABI::AugmentRegisterInfo(RegisterInfo &info) {
std::string name_upper = llvm::StringRef(info.name).upper();
uint32_t eh, dwarf;
std::tie(eh, dwarf) = GetEHAndDWARFNums(name_upper);
if (info.kinds[eRegisterKindEHFrame] == LLDB_INVALID_REGNUM)
info.kinds[eRegisterKindEHFrame] = eh;
if (info.kinds[eRegisterKindDWARF] == LLDB_INVALID_REGNUM)
info.kinds[eRegisterKindDWARF] = dwarf;
if (info.kinds[eRegisterKindGeneric] == LLDB_INVALID_REGNUM)
info.kinds[eRegisterKindGeneric] = GetGenericNum(name_upper);
}
std::pair<uint32_t, uint32_t>
MCBasedABI::GetEHAndDWARFNums(llvm::StringRef name) {
std::string mc_name = GetMCName(name.str());
int eh = -1;
int dwarf = -1;
jasonmolendaUnsubmitted
Done
ReplyInline Actions

Would it be simpler to assign these to LLDB_INVALID_REGNUM at the beginning, instead of -1 and setting it later?

jasonmolenda: Would it be simpler to assign these to `LLDB_INVALID_REGNUM` at the beginning, instead of -1…
labathAuthorUnsubmitted
Done
ReplyInline Actions

Not really, because the MC interface uses -1 to denote registers which don't have a dwarf number. (In fact some of the things in the MC list are not even really registers, but more like combinations of registers that are sometimes handy when grouped (Q0_Q1, etc.)

labath: Not really, because the MC interface uses -1 to denote registers which don't have a dwarf…
for (unsigned reg = 0; reg < m_mc_register_info_up->getNumRegs(); ++reg) {
if (m_mc_register_info_up->getName(reg) == mc_name) {
eh = m_mc_register_info_up->getDwarfRegNum(reg, /*isEH=*/true);
dwarf = m_mc_register_info_up->getDwarfRegNum(reg, /*isEH=*/false);
break;
}
}
return std::pair<uint32_t, uint32_t>(eh == -1 ? LLDB_INVALID_REGNUM : eh,
dwarf == -1 ? LLDB_INVALID_REGNUM
: dwarf);
}
void MCBasedABI::MapName(std::string &name, llvm::StringRef from_prefix,
llvm::StringRef to_prefix) {
llvm::StringRef name_ref = name;
uint64_t _;
if (name_ref.consume_front(from_prefix) && to_integer(name_ref, _, 10))
name = (to_prefix + name_ref).str();
jasonmolendaUnsubmitted
Done
ReplyInline Actions

will to_integer bit work with an all-letter reg like cpsr?

jasonmolenda: will `to_integer` bit work with an all-letter reg like `cpsr`?
labathAuthorUnsubmitted
Done
ReplyInline Actions

We didn't need this functionality yet because we weren't renaming any singular registers, but I've now added code to handle this too.

labath: We didn't need this functionality yet because we weren't renaming any singular registers, but…
}

lldb/unittests/Target/ABITest.cpp

  • This file was added.
//===-- ABITest.cpp -------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "lldb/Target/ABI.h"
#include "gtest/gtest.h"
using namespace lldb_private;
TEST(MCBasedABI, MapName) {
auto map = [](std::string name) {
MCBasedABI::MapName(name, "foo", "bar");
return name;
};
EXPECT_EQ("bar0", map("foo0"));
EXPECT_EQ("bar47", map("foo47"));
EXPECT_EQ("foo47x", map("foo47x"));
EXPECT_EQ("fooo47", map("fooo47"));
EXPECT_EQ("bar47", map("bar47"));
}

lldb/unittests/Target/CMakeLists.txt

add_lldb_unittest(TargetTests add_lldb_unittest(TargetTests
ABITest.cpp
ExecutionContextTest.cpp ExecutionContextTest.cpp
MemoryRegionInfoTest.cpp MemoryRegionInfoTest.cpp
ModuleCacheTest.cpp ModuleCacheTest.cpp
PathMappingListTest.cpp PathMappingListTest.cpp
StackFrameRecognizerTest.cpp StackFrameRecognizerTest.cpp
LINK_LIBS LINK_LIBS
lldbCore lldbCore
Show All 13 Lines