This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Remove check for illegal MIR
ClosedPublic

Authored by arsenm on Feb 4 2020, 1:07 PM.

Reviewers

Summary

The verifier will catch this.

This revision is now accepted and ready to land.Feb 5 2020, 3:03 PM

Path

Size

llvm/

lib/

CodeGen/

GlobalISel/

2 lines

Show First 20 Lines • Show All 1,122 Lines • ▼ Show 20 Lines	case TargetOpcode::G_ICMP: {
Observer.changedInstr(MI);		Observer.changedInstr(MI);
MI.eraseFromParent();		MI.eraseFromParent();
return Legalized;		return Legalized;
}		}
case TargetOpcode::G_SEXT_INREG: {		case TargetOpcode::G_SEXT_INREG: {
if (TypeIdx != 0)		if (TypeIdx != 0)
return UnableToLegalize;		return UnableToLegalize;

if (!MI.getOperand(2).isImm())
return UnableToLegalize;
int64_t SizeInBits = MI.getOperand(2).getImm();		int64_t SizeInBits = MI.getOperand(2).getImm();

// So long as the new type has more bits than the bits we're extending we		// So long as the new type has more bits than the bits we're extending we
// don't need to break it apart.		// don't need to break it apart.
if (NarrowTy.getScalarSizeInBits() >= SizeInBits) {		if (NarrowTy.getScalarSizeInBits() >= SizeInBits) {
Observer.changingInstr(MI);		Observer.changingInstr(MI);
// We don't lose any non-extension bits by truncating the src and		// We don't lose any non-extension bits by truncating the src and
// sign-extending the dst.		// sign-extending the dst.
▲ Show 20 Lines • Show All 3,814 Lines • Show Last 20 Lines