This is an archive of the discontinued LLVM Phabricator instance.

Differential D73986

[nfc][mlir] Mark the MLIR tools for installation in CMake
ClosedPublic

Authored by kernhanda on Feb 4 2020, 11:38 AM.

Details

Reviewers
mehdi_amini
nicolasvasilache
ftynse
Commits
rG211aa5bf59eb: [mlir] Mark the MLIR tools for installation in CMake
rGb8004b7308b4: [mlir] Mark the MLIR tools for installation in CMake
Summary

This binplaces mlir-translate, mlir-cuda-runner, and mlir-cpu-runner when building the CMake install target.

Diff Detail

Event Timeline

kernhanda created this revision.Feb 4 2020, 11:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2020, 11:38 AM
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 10 others. · View Herald Transcript
kernhanda edited the summary of this revision. (Show Details)Feb 4 2020, 11:38 AM
merge_guards_bot added a subscriber: merge_guards_bot.Feb 4 2020, 11:59 AM

Unit tests: unknown.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Harbormaster failed remote builds in B45705: Diff 242387!Feb 4 2020, 12:03 PM
mehdi_amini accepted this revision.Feb 4 2020, 3:20 PM
This revision is now accepted and ready to land.Feb 4 2020, 3:20 PM
kernhanda added a comment.Feb 4 2020, 3:24 PM

I'll need someone to commit this on my behalf since I don't have sufficient privileges.

Also, should this change be merged into the LLVM 10.x release branch? Is that automatic?

Closed by commit rGb8004b7308b4: [mlir] Mark the MLIR tools for installation in CMake (authored by kernhanda, committed by • joker-eph-DISABLED). · Explain WhyFeb 4 2020, 7:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
tools/
mlir-cpu-runner/
2 lines
mlir-cuda-runner/
2 lines
mlir-translate/
2 lines

Diff 242387

mlir/tools/mlir-cpu-runner/CMakeLists.txt

add_llvm_executable(mlir-cpu-runner add_llvm_tool(mlir-cpu-runner
mlir-cpu-runner.cpp mlir-cpu-runner.cpp
) )
llvm_update_compile_flags(mlir-cpu-runner) llvm_update_compile_flags(mlir-cpu-runner)
whole_archive_link(mlir-cpu-runner whole_archive_link(mlir-cpu-runner
MLIRAffineOps MLIRAffineOps
MLIRLLVMIR MLIRLLVMIR
MLIRTargetLLVMIR MLIRTargetLLVMIR
MLIRTranslation MLIRTranslation
Show All 14 Lines

mlir/tools/mlir-cuda-runner/CMakeLists.txt

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines set(LIBS
MLIRAnalysis MLIRAnalysis
MLIRExecutionEngine MLIRExecutionEngine
MLIRJitRunner MLIRJitRunner
MLIRSupport MLIRSupport
LLVMCore LLVMCore
LLVMSupport LLVMSupport
${CUDA_RUNTIME_LIBRARY} ${CUDA_RUNTIME_LIBRARY}
) )
add_llvm_executable(mlir-cuda-runner add_llvm_tool(mlir-cuda-runner
mlir-cuda-runner.cpp mlir-cuda-runner.cpp
) )
add_dependencies(mlir-cuda-runner cuda-runtime-wrappers) add_dependencies(mlir-cuda-runner cuda-runtime-wrappers)
target_include_directories(mlir-cuda-runner target_include_directories(mlir-cuda-runner
PRIVATE ${CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES} PRIVATE ${CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES}
) )
llvm_update_compile_flags(mlir-cuda-runner) llvm_update_compile_flags(mlir-cuda-runner)
whole_archive_link(mlir-cuda-runner ${FULL_LINK_LIBS}) whole_archive_link(mlir-cuda-runner ${FULL_LINK_LIBS})
target_link_libraries(mlir-cuda-runner PRIVATE ${FULL_LINK_LIBS} ${LIBS}) target_link_libraries(mlir-cuda-runner PRIVATE ${FULL_LINK_LIBS} ${LIBS})
endif() endif()

mlir/tools/mlir-translate/CMakeLists.txt

set(LIBS set(LIBS
MLIRParser MLIRParser
MLIRPass MLIRPass
MLIRSPIRV MLIRSPIRV
MLIRSPIRVSerialization MLIRSPIRVSerialization
MLIRTargetLLVMIR MLIRTargetLLVMIR
MLIRTargetNVVMIR MLIRTargetNVVMIR
MLIRTargetROCDLIR MLIRTargetROCDLIR
MLIRTranslation MLIRTranslation
MLIRSupport MLIRSupport
) )
add_llvm_executable(mlir-translate add_llvm_tool(mlir-translate
mlir-translate.cpp mlir-translate.cpp
) )
llvm_update_compile_flags(mlir-translate) llvm_update_compile_flags(mlir-translate)
whole_archive_link(mlir-translate ${LIBS}) whole_archive_link(mlir-translate ${LIBS})
target_link_libraries(mlir-translate PRIVATE MLIRIR MLIRTranslateClParser ${LIBS} LLVMSupport) target_link_libraries(mlir-translate PRIVATE MLIRIR MLIRTranslateClParser ${LIBS} LLVMSupport)