sigaltstack interception is implemented D73816. This updated OpenBSD and Solaris bits to fix the build errors.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Hi @mgorny and @krytarowski! This is my best effort fixing build errors caused by D73816. I don't have a good way to build and test it on NetBSD and would need your help with this.
Comment Actions
NetBSD fix landed here:
commit b79b7674eb470963d0b558022a843c55b0b0ffe0 Author: Kamil Rytarowski <n54@gmx.com> Date: Tue Feb 4 23:30:05 2020 +0100 [compiler-rt] [netbsd] Fix build after "implement sigaltstack interception" Fallout after: https://reviews.llvm.org/D73816
For the other OSs that were added later I cannot tell neither test anything so I resign as a reviewer.
Comment Actions
Looks like FreeBSD was also fixed in:
commit 8a1f4feb1b749529ef2349bb7879a38b8d31f5f5 Author: Dimitry Andric <dimitry@andric.com> Date: Tue Feb 4 22:50:05 2020 +0100 [compiler-rt] Fix sanitizer_common build for FreeBSD This was broken by 28c91219c7e2, which added `struct_stack_t_sz` only to sanitizer_platform_limits_posix.{cpp,h}.
@eugenis what do you suggest we do with the remaining changes that affect solaris and OpenBSD?
Comment Actions
I always get confused with *bsd targets being under "posix" in most places, getting lumped together with linux in some other files, but having their own platform_limits.
I'm not going to test it, but this change is more likely to make things better than the opposite. May as well land it.
LGTM