Page MenuHomePhabricator

sugak (Igor Sugak)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 12:00 AM (260 w, 5 d)

Recent Activity

Feb 10 2020

sugak added a comment to D73816: [compiler-rt] implement sigaltstack interception.

Yes, I'll fix this!

Feb 10 2020, 4:33 PM · Restricted Project, Restricted Project
sugak added a comment to D73816: [compiler-rt] implement sigaltstack interception.

@eugenis: would you want me to send a patch for it or are you looking at this?

Feb 10 2020, 3:36 PM · Restricted Project, Restricted Project

Feb 4 2020

sugak added a comment to D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.

@eugenis: good! Please push this for me. Thank you!

Feb 4 2020, 3:45 PM · Restricted Project, Restricted Project
sugak updated the diff for D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.

Rebase

Feb 4 2020, 3:10 PM · Restricted Project, Restricted Project
sugak added a comment to D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.

Looks like FreeBSD was also fixed in:

commit 8a1f4feb1b749529ef2349bb7879a38b8d31f5f5
Author: Dimitry Andric <dimitry@andric.com>
Date:   Tue Feb 4 22:50:05 2020 +0100
Feb 4 2020, 3:09 PM · Restricted Project, Restricted Project
sugak updated the diff for D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.

include likely fixes for FreeBSD and OpenBSD.

Feb 4 2020, 1:46 PM · Restricted Project, Restricted Project
sugak created D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.
Feb 4 2020, 10:03 AM · Restricted Project, Restricted Project
sugak added a comment to D73816: [compiler-rt] implement sigaltstack interception.

Sorry for breaking NetBSD builds! An attempt to fix it in D73976.

Feb 4 2020, 10:03 AM · Restricted Project, Restricted Project
sugak added a comment to D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.

Hi @mgorny and @krytarowski! This is my best effort fixing build errors caused by D73816. I don't have a good way to build and test it on NetBSD and would need your help with this.

Feb 4 2020, 10:03 AM · Restricted Project, Restricted Project
sugak updated the summary of D73976: [compiler-rt] fix OpenBSD and Solaris build with sigaltstack interception.
Feb 4 2020, 10:03 AM · Restricted Project, Restricted Project

Feb 3 2020

sugak added a comment to D73816: [compiler-rt] implement sigaltstack interception.

@eugenis, thank you for the review! Would you please commit this for me?

Feb 3 2020, 4:13 PM · Restricted Project, Restricted Project
sugak updated the diff for D73816: [compiler-rt] implement sigaltstack interception.

Thank you @eugenis! I've updated the change with you feedback and added a test.

Feb 3 2020, 11:29 AM · Restricted Project, Restricted Project

Jan 31 2020

sugak added a comment to D73816: [compiler-rt] implement sigaltstack interception.

I manually tested this on CentOS and would need guidance about the use of SI_POSIX, as well as how to make a unittest for this (if needed).

Jan 31 2020, 3:58 PM · Restricted Project, Restricted Project
sugak created D73816: [compiler-rt] implement sigaltstack interception.
Jan 31 2020, 3:49 PM · Restricted Project, Restricted Project

Dec 19 2019

sugak updated the summary of D71731: [Format] fix dereference of pointers in co_yeld and co_return statements.
Dec 19 2019, 3:54 PM · Restricted Project
sugak created D71731: [Format] fix dereference of pointers in co_yeld and co_return statements.
Dec 19 2019, 3:54 PM · Restricted Project

Aug 22 2019

sugak accepted D66624: [sanitizer] Resubmit D66620 from monorepo.
Aug 22 2019, 4:31 PM · Restricted Project, Restricted Project
sugak added a comment to D66620: [sanitizer] Update symbolizer/scripts.

Could that be due to the fact that I made this change from compiler-rt.git and not the monorepo?

Aug 22 2019, 4:15 PM · Restricted Project, Restricted Project
sugak created D66620: [sanitizer] Update symbolizer/scripts.
Aug 22 2019, 2:18 PM · Restricted Project, Restricted Project

Oct 31 2018

sugak added a comment to D53910: [Ubsan] link minimal Ubsan into full Ubsan.

Great, let me create another iteration and add the -fsanitize-minimal flag, I'll see if I can split it up into small changes.

Oct 31 2018, 3:23 PM

Oct 30 2018

sugak added a comment to D53910: [Ubsan] link minimal Ubsan into full Ubsan.

@vitalybuka I was thinking of this too, we could rename -fsanitize-minimal-runtime flag, or convert it into something similar how -fsanitize= or -fsanitize-trap= works:

-fsanitize=bool -fsanitize-minimal=null
Oct 30 2018, 5:30 PM
sugak added a comment to D53910: [Ubsan] link minimal Ubsan into full Ubsan.

Hi @eugenis, I think I've implemented this as you suggested on the mailing list, please let me know if this makes sense.

Oct 30 2018, 4:42 PM
sugak created D53910: [Ubsan] link minimal Ubsan into full Ubsan.
Oct 30 2018, 4:38 PM

Oct 29 2018

sugak added a comment to D53826: [ubsan-minimal] update comments in CMakeLists.txt.

@eugenis, please push this for me!

Oct 29 2018, 1:36 PM
sugak created D53826: [ubsan-minimal] update comments in CMakeLists.txt.
Oct 29 2018, 12:27 PM

Dec 21 2017

sugak created D41531: [DebugInfo/DWARF] generate aranges for CU even if it has .debug_aranges entry.
Dec 21 2017, 4:33 PM · debug-info

Nov 7 2017

sugak added a comment to D39478: [clang-format] Handle leading comments in using declaration.

@djasper: no, I do not.

Nov 7 2017, 10:25 AM

Nov 6 2017

sugak added a comment to D39478: [clang-format] Handle leading comments in using declaration.

@djasper: ping :)

Nov 6 2017, 1:07 PM

Nov 3 2017

sugak added a comment to D39587: [clang-format] Handle unary operator overload with arguments and specifiers.

@djasper: would you accept and push this for me :)

Nov 3 2017, 11:06 AM

Nov 2 2017

sugak created D39587: [clang-format] Handle unary operator overload with arguments and specifiers.
Nov 2 2017, 9:19 PM

Nov 1 2017

sugak updated the diff for D39478: [clang-format] Handle leading comments in using declaration.

Updated per comments.

Nov 1 2017, 12:34 PM

Oct 31 2017

sugak added inline comments to D39478: [clang-format] Handle leading comments in using declaration.
Oct 31 2017, 3:02 PM
sugak created D39478: [clang-format] Handle leading comments in using declaration.
Oct 31 2017, 2:40 PM

May 4 2017

sugak abandoned D32883: [LLVMgold] add option to statically link libstdc++ and libgcc.

I didn't know about CMAKE_MODULE_LINK_FLAGS! Confirming that the following achieves the same result as the proposed diff:

cmake . . . -DCMAKE_MODULE_LINKER_FLAGS='-static-libgcc -static-libstdc++'
May 4 2017, 3:57 PM
sugak updated the summary of D32883: [LLVMgold] add option to statically link libstdc++ and libgcc.
May 4 2017, 3:27 PM
sugak updated subscribers of D32883: [LLVMgold] add option to statically link libstdc++ and libgcc.
May 4 2017, 3:26 PM
sugak created D32883: [LLVMgold] add option to statically link libstdc++ and libgcc.
May 4 2017, 3:26 PM

Sep 30 2016

sugak added reviewers for D25153: preprocessor supports `-dI` flag: rsmith, cfe-commits.
Sep 30 2016, 8:14 PM

Jun 7 2016

sugak abandoned D21044: [tsan]: rename RunningOnValgrind to __tsan_RunningOnValgrind.

Thank you for the explanation @dvyukov! I don't remember exactly how gperftools was used in a project where I noticed the symbol name conflict. I'll try to reproduce it, and will post here for the record.
Abandoning this.

Jun 7 2016, 9:05 AM
sugak added a comment to D21050: [clang-tidy] correct clang-tidy-diff.py help message.

Thank you for the review! I need someone to commit this for me :)

Jun 7 2016, 8:54 AM

Jun 6 2016

sugak added inline comments to D21050: [clang-tidy] correct clang-tidy-diff.py help message.
Jun 6 2016, 7:15 PM
sugak retitled D21050: [clang-tidy] correct clang-tidy-diff.py help message from to [clang-tidy] correct clang-tidy-diff.py help message.
Jun 6 2016, 5:49 PM
sugak updated D21044: [tsan]: rename RunningOnValgrind to __tsan_RunningOnValgrind.
Jun 6 2016, 3:08 PM
sugak retitled D21044: [tsan]: rename RunningOnValgrind to __tsan_RunningOnValgrind from to [tsan]: rename RunningOnValgrind to __tsan_RunningOnValgrind.
Jun 6 2016, 3:06 PM

Feb 11 2016

sugak added a comment to D17049: [CMake] don't build libLTO when LLVM_ENABLE_PIC is OFF.

I need someone to commit this for me.

Feb 11 2016, 7:38 PM

Feb 10 2016

sugak added a comment to D17049: [CMake] don't build libLTO when LLVM_ENABLE_PIC is OFF.

@joker.eph: yes, in environments that don't set CYGWIN, after r252652 libLTO is always built, regardless of LLVM_ENABLE_PIC.

Feb 10 2016, 9:43 AM
sugak updated D17049: [CMake] don't build libLTO when LLVM_ENABLE_PIC is OFF.
Feb 10 2016, 9:19 AM
sugak updated subscribers of D17049: [CMake] don't build libLTO when LLVM_ENABLE_PIC is OFF.
Feb 10 2016, 9:04 AM

Feb 9 2016

sugak retitled D17049: [CMake] don't build libLTO when LLVM_ENABLE_PIC is OFF from to [CMake] don't build libLTO when LLVM_ENABLE_PIC is OFF.
Feb 9 2016, 3:30 PM

Feb 2 2016

sugak added a comment to D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1.

@rsmith: yes, I need someone to commit this.

Feb 2 2016, 2:06 PM
sugak retitled D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1 from to Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1.
Feb 2 2016, 12:58 PM