Page MenuHomePhabricator

Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering"
ClosedPublic

Authored by tlively on Feb 3 2020, 2:39 PM.

Details

Summary

This reverts commit 3ef169e586f4d14efe690c23c878d5aa92a80eb5. The
purpose of this commit was to allow stack machines to perform
instruction selection for instructions with variadic defs. However,
MachineInstrs fundamentally cannot support variadic defs right now, so
this change does not turn out to be useful.

Depends on D73927.

Diff Detail

Event Timeline

tlively created this revision.Feb 3 2020, 2:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2020, 2:40 PM

Unit tests: pass. 62432 tests passed, 0 failed and 845 were skipped.

clang-tidy: fail. clang-tidy found 0 errors and 1 warnings. 0 of them are added as review comments below (why?).

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

aheejin accepted this revision.Feb 4 2020, 2:20 PM
This revision is now accepted and ready to land.Feb 4 2020, 2:20 PM
This revision was automatically updated to reflect the committed changes.