Page MenuHomePhabricator

[VE] half fptrunc+store&load+fpext
ClosedPublic

Authored by simoll on Feb 3 2020, 8:24 AM.

Details

Summary

fp16 (half) load+fpext and fptrunc+store isel legalization and tests.
Also, ExternalSymbolSDNode operand printing (tested by fp16 lowering).

Diff Detail

Event Timeline

simoll created this revision.Feb 3 2020, 8:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2020, 8:24 AM

Unit tests: pass. 62417 tests passed, 0 failed and 845 were skipped.

clang-tidy: fail. clang-tidy found 2 errors and 0 warnings. 0 of them are added as review comments below (why?).

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

simoll updated this revision to Diff 242303.Feb 4 2020, 5:29 AM
  • formatting (lint)
  • rebased

Unit tests: pass. 62440 tests passed, 0 failed and 845 were skipped.

clang-tidy: fail. clang-tidy found 2 errors and 0 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

arsenm accepted this revision.Feb 4 2020, 6:22 AM

LGTM

llvm/test/CodeGen/VE/fp_extload_truncstore.ll
3–4

I thought these were removed?

This revision is now accepted and ready to land.Feb 4 2020, 6:22 AM
simoll marked 2 inline comments as done.Feb 4 2020, 8:19 AM

thx!

llvm/test/CodeGen/VE/fp_extload_truncstore.ll
3–4

They still exist. We will strip them from the backend when they are gone for good.

This revision was automatically updated to reflect the committed changes.
simoll marked an inline comment as done.