Page MenuHomePhabricator

[mlir] Added RankedIntElementsAttr class
ClosedPublic

Authored by Joonsoo on Thu, Jan 30, 8:49 PM.

Details

Summary

Defines a tablegen class RankedIntElementsAttr. This is an integer version of RankedFloatElementsAttr.

Diff Detail

Event Timeline

Joonsoo created this revision.Thu, Jan 30, 8:49 PM
Herald added 1 blocking reviewer(s): rriddle. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Joonsoo retitled this revision from Added RankedIntElementsAttr class to [mlir] Added RankedIntElementsAttr class.Thu, Jan 30, 8:50 PM
Joonsoo edited the summary of this revision. (Show Details)

Unit tests: fail. 62357 tests passed, 1 failed and 839 were skipped.

failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

ftynse requested changes to this revision.Fri, Jan 31, 12:25 AM
ftynse added a subscriber: ftynse.
ftynse added inline comments.
mlir/include/mlir/IR/OpBase.td
1047

Would it be possible to make this a bit more readable than a 7-line flow of tokens? One suggestion is to use (1) reuse the predicate of IntElementsAttr and (2) use the And class to combine predicates instead of manual "&&". We actually have an expression simplifier in the op that relies on that.

1052

Drop llvm::, ArrayRef is re-exported into the mlir namespace

This revision now requires changes to proceed.Fri, Jan 31, 12:25 AM
Joonsoo updated this revision to Diff 242257.Mon, Feb 3, 10:11 PM
Joonsoo marked 2 inline comments as done.

Fixed compile error and improve readability

Joonsoo updated this revision to Diff 242263.Mon, Feb 3, 10:36 PM

Restored missing conditions

Joonsoo updated this revision to Diff 242264.Mon, Feb 3, 10:45 PM
Joonsoo marked an inline comment as not done.

Improve predicate readability

Joonsoo marked an inline comment as done.Mon, Feb 3, 10:48 PM

Unit tests: fail. 62356 tests passed, 2 failed and 839 were skipped.

failed: MLIR.IR/attribute.mlir
failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Unit tests: fail. 62357 tests passed, 1 failed and 839 were skipped.

failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Unit tests: fail. 62357 tests passed, 1 failed and 839 were skipped.

failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

ftynse accepted this revision.Tue, Feb 4, 12:56 AM

LGTM after one nit is fixed.

mlir/include/mlir/IR/OpBase.td
1058

Drop llvm::, ArrayRef is re-exported into the mlir namespace

Joonsoo updated this revision to Diff 242519.Wed, Feb 5, 12:06 AM

Drop llvm:: from llvm::makeArrayRef

Joonsoo marked an inline comment as done.Wed, Feb 5, 12:19 AM

Unit tests: fail. 62357 tests passed, 1 failed and 839 were skipped.

failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

antiagainst accepted this revision.Wed, Feb 5, 6:30 AM

LGTM, just two nits regarding the test names.

mlir/test/IR/attribute.mlir
276

wrong_shape_fail ?

287

wrong_shape_fail ?

Joonsoo updated this revision to Diff 243090.Thu, Feb 6, 11:27 PM

Fixed test case names

Joonsoo marked 2 inline comments as done.Thu, Feb 6, 11:28 PM
antiagainst accepted this revision.Sat, Feb 8, 4:05 AM
Joonsoo removed a reviewer: rriddle.Sun, Feb 9, 7:05 PM
This revision is now accepted and ready to land.Sun, Feb 9, 7:05 PM
This revision now requires review to proceed.Sun, Feb 9, 7:05 PM
rriddle accepted this revision.Sun, Feb 9, 10:45 PM
This revision is now accepted and ready to land.Sun, Feb 9, 10:45 PM
This revision was automatically updated to reflect the committed changes.