Rename prettyprinters test to llvm-support.

[csigg]

Summary

Make room for mlir-support pretty printers that I would like to add next.

[merge_guards_bot]

Unit tests: pass. 62322 tests passed, 0 failed and 838 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

[dblaikie]

I /think/ including "llvm" in the name is helpful, even if it connotes the llvm umbrella project rather than just llvm proper (clang, llvm, mlir, whatever) - which is different from tests intended to validate LLVM's external usability.

So I'd have a minor vote for llvm-visualizers? (including "tests" in the name is probably unnecessary since this whole repository is for tests?)

[csigg]

Ok.

Maybe I should just leave the directory as is and only rename the files?

[csigg]

Revert back to llvm-prettyprinters directory.

[merge_guards_bot]

Unit tests: pass. 62322 tests passed, 0 failed and 838 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

[dblaikie]

Looks good, thanks!

debuginfo-tests/CMakeLists.txt

 # Debug Info tests.  These tests invoke clang to generate programs with
 # various types of debug info, and then run those programs under a debugger
 # such as GDB or LLDB to verify the results.
 
-add_llvm_executable(prettyprinters
-        llvm-prettyprinters/gdb/prettyprinters.cpp
+add_llvm_executable(llvm-support
+        visualizer-tests/gdb/llvm-support.cpp
 )
-target_link_libraries(prettyprinters PRIVATE LLVMSupport)
+target_link_libraries(llvm-support PRIVATE LLVMSupport)
 
 set(DEBUGINFO_TESTS_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
 set(DEBUGINFO_TESTS_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
 
 set(DEBUGINFO_TEST_DEPS
   clang
   FileCheck
   count
   llvm-objdump
+  llvm-support
   not
-  prettyprinters
   )
 
 # The Windows builder scripts pass -fuse-ld=lld.
 if (WIN32)
   set(DEBUGINFO_TEST_DEPS ${DEBUGINFO_TEST_DEPS} lld)
 endif()
 
 if (NOT DEFINED PYTHON_EXECUTABLE)

debuginfo-tests/visualizer-tests/gdb/lit.local.cfg

 import lit.util
 
 # debuginfo-tests are not expected to pass in a cross-compilation setup.
 if 'native' not in config.available_features or lit.util.which('gdb') is None:
     config.unsupported = True
 
 config.suffixes = ['.gdb']
 
 

debuginfo-tests/visualizer-tests/gdb/llvm-support.cpp

 }();
 auto SimpleIlist = []() {
   llvm::simple_ilist<IlistNode, SimpleIlistTag> Result;
   for (auto &Node : Ilist)
     Result.push_front(Node);
   return Result;
 }();
 
+// Check expected instances to avoid compile errors.
+auto CheckExpectedValue = static_cast<bool>(ExpectedValue);
+auto CheckExpectedError = static_cast<bool>(ExpectedError);
+
 int main() { return 0; }

debuginfo-tests/visualizer-tests/gdb/llvm-support.gdb

-# RUN: gdb -q -batch -n -iex 'source %llvm_src_root/utils/gdb-scripts/prettyprinters.py' -x %s %llvm_tools_dir/prettyprinters | FileCheck %s
+# RUN: gdb -q -batch -n -iex 'source %llvm_src_root/utils/gdb-scripts/prettyprinters.py' -x %s %llvm_tools_dir/llvm-support | FileCheck %s
 
 break main
 run
 
 # CHECK: llvm::ArrayRef of length 3 = {1, 2, 3}
 p ArrayRef
 
 # CHECK: llvm::ArrayRef of length 3 = {1, 2, 3}