This is an archive of the discontinued LLVM Phabricator instance.

Rename prettyprinters test to llvm-support.
ClosedPublic

Authored by csigg on Jan 30 2020, 10:24 AM.

Details

Summary

Make room for mlir-support pretty printers that I would like to add next.

Diff Detail

Event Timeline

csigg created this revision.Jan 30 2020, 10:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2020, 10:24 AM

Unit tests: pass. 62322 tests passed, 0 failed and 838 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

I /think/ including "llvm" in the name is helpful, even if it connotes the llvm umbrella project rather than just llvm proper (clang, llvm, mlir, whatever) - which is different from tests intended to validate LLVM's external usability.

So I'd have a minor vote for llvm-visualizers? (including "tests" in the name is probably unnecessary since this whole repository is for tests?)

Ok.

Maybe I should just leave the directory as is and only rename the files?

csigg updated this revision to Diff 242028.Feb 3 2020, 5:02 AM

Revert back to llvm-prettyprinters directory.

csigg retitled this revision from Rename llvm-prettyprinters to visualizer-tests. to Rename prettyprinters test to llvm-support..Feb 3 2020, 5:03 AM
csigg edited the summary of this revision. (Show Details)

Unit tests: pass. 62322 tests passed, 0 failed and 838 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

dblaikie accepted this revision.Feb 4 2020, 8:24 PM

Looks good, thanks!

This revision is now accepted and ready to land.Feb 4 2020, 8:24 PM
This revision was automatically updated to reflect the committed changes.