This is an archive of the discontinued LLVM Phabricator instance.

Differential D73715

- Update .clang-tidy to ignore parameters of main like functions for naming violations in clang and llvm directory
ClosedPublic

Authored by njames93 on Jan 30 2020, 8:12 AM.

Details

Reviewers
alexfh
hokein
Commits
rGf99133e853bf: - Update .clang-tidy to ignore parameters of main like functions for naming…
rGc3d20fd47200: [clang-tidy] readability-identifier-naming disregards parameters restrictions…
Summary

Every call to a main like function in llvm and clang lib violates the naming convention for parameters. This prevents clang-tidy warning on such breaches.

Diff Detail

Event Timeline

njames93 created this revision.Jan 30 2020, 8:12 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 30 2020, 8:12 AM
Herald added subscribers: llvm-commits, cfe-commits, aheejin. · View Herald Transcript
njames93 marked an inline comment as done.Jan 30 2020, 8:13 AM
njames93 added inline comments.
clang/.clang-tidy
23

Although identifier-naming is disabled, its still a good idea to include this just in case people run clang tidy manually

njames93 added a commit: rGc3d20fd47200: [clang-tidy] readability-identifier-naming disregards parameters restrictions….Jan 30 2020, 8:24 AM
merge_guards_bot added a subscriber: merge_guards_bot.Jan 30 2020, 8:26 AM

Unit tests: pass. 62329 tests passed, 0 failed and 838 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Harbormaster completed remote builds in B45353: Diff 241471.Jan 30 2020, 8:32 AM
hokein accepted this revision.Jan 31 2020, 12:58 AM

thanks, looks good.

This revision is now accepted and ready to land.Jan 31 2020, 12:58 AM
Closed by commit rGf99133e853bf: - Update .clang-tidy to ignore parameters of main like functions for naming… (authored by njames93). · Explain WhyJan 31 2020, 8:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
2 lines
clang/
2 lines
llvm/
2 lines

Diff 241745

.clang-tidy

Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming' Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming'
CheckOptions: CheckOptions:
- key: readability-identifier-naming.ClassCase - key: readability-identifier-naming.ClassCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.EnumCase - key: readability-identifier-naming.EnumCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.FunctionCase - key: readability-identifier-naming.FunctionCase
value: camelBack value: camelBack
- key: readability-identifier-naming.MemberCase - key: readability-identifier-naming.MemberCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.ParameterCase - key: readability-identifier-naming.ParameterCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.UnionCase - key: readability-identifier-naming.UnionCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.VariableCase - key: readability-identifier-naming.VariableCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.IgnoreMainLikeFunctions
value: 1

clang/.clang-tidy

Show All 13 LinesCheckOptions:
- key: readability-identifier-naming.MemberCase - key: readability-identifier-naming.MemberCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.ParameterCase - key: readability-identifier-naming.ParameterCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.UnionCase - key: readability-identifier-naming.UnionCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.VariableCase - key: readability-identifier-naming.VariableCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.IgnoreMainLikeFunctions
value: 1
njames93AuthorUnsubmitted
Done
ReplyInline Actions

Although identifier-naming is disabled, its still a good idea to include this just in case people run clang tidy manually

njames93: Although identifier-naming is disabled, its still a good idea to include this just in case…

llvm/.clang-tidy

Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming' Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming'
CheckOptions: CheckOptions:
- key: readability-identifier-naming.ClassCase - key: readability-identifier-naming.ClassCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.EnumCase - key: readability-identifier-naming.EnumCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.FunctionCase - key: readability-identifier-naming.FunctionCase
value: camelBack value: camelBack
- key: readability-identifier-naming.MemberCase - key: readability-identifier-naming.MemberCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.ParameterCase - key: readability-identifier-naming.ParameterCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.UnionCase - key: readability-identifier-naming.UnionCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.VariableCase - key: readability-identifier-naming.VariableCase
value: CamelCase value: CamelCase
- key: readability-identifier-naming.IgnoreMainLikeFunctions
value: 1