Page MenuHomePhabricator

Don't mark MIPS TRAP as isTerminator
ClosedPublic

Authored by arichardson on Jan 29 2020, 10:38 AM.

Details

Summary

This was causing machine verifier errors when compiling libunwind.
I am not 100% certain the flags are correct, I simply copied the flags
that AArch64 and X86 use.

Diff Detail

Event Timeline

arichardson created this revision.Jan 29 2020, 10:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 29 2020, 10:38 AM

Unit tests: fail. 62293 tests passed, 1 failed and 834 were skipped.

failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/try_lock.pass.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

atanasyan accepted this revision.Jan 29 2020, 2:34 PM

LGTM
Thanks

This revision is now accepted and ready to land.Jan 29 2020, 2:34 PM
This revision was automatically updated to reflect the committed changes.