This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GlobalISel] Select 8-byte LDS Ops with 4-byte alignment
ClosedPublic

Authored by kerbowa on Jan 28 2020, 2:32 PM.

Event Timeline

kerbowa created this revision.Jan 28 2020, 2:32 PM
arsenm added inline comments.Jan 28 2020, 2:42 PM
llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
2353

This can use getPtrBaseWithConstantOffset and avoid re-figuring out the offset below

2371

G_SUB isn't pointer typed, so this would never happen. This would require looking through G_INTTOPTR

kerbowa added inline comments.Jan 28 2020, 8:48 PM
llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
2353

I'll update selectDS1Addr1OffsetImpl too in another patch when I add the constant Addr bits there.

2371

Okay. selectDS1Addr1OffsetImpl needs these implemented as well.

kerbowa updated this revision to Diff 241046.Jan 28 2020, 9:06 PM

Use getPtrBaseWithConstantOffset.

arsenm accepted this revision.Jan 29 2020, 6:58 AM
This revision is now accepted and ready to land.Jan 29 2020, 6:58 AM
This revision was automatically updated to reflect the committed changes.