change https://reviews.llvm.org/D64725 removes “isDivergent” predicates from the scalar shifts.
As a result we easy can select S_LSHL_B32 for divergent arguments.
Details
Diff Detail
Event Timeline
Is there a test for scalar selection?
llvm/lib/Target/AMDGPU/VOP2Instructions.td | ||
---|---|---|
548 | Any tests for GFX10 on this? | |
llvm/lib/Target/AMDGPU/VOP3Instructions.td | ||
388 | Any tests for GFX10 on this? | |
llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir | ||
2 | Ugh... Fiji is GFX8. Instead of dropping test for tahiti just fix the check-prefix for fiji. |
llvm/lib/Target/AMDGPU/VOP2Instructions.td | ||
---|---|---|
548 | But we need a gfx10 test to check proper selection of IR shifts. I do not see these tests. | |
llvm/test/CodeGen/AMDGPU/GlobalISel/extractelement.ll | ||
982 | It does not belong to this change. Please generate a proper diff. | |
llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir | ||
2 | Please return the dropped tahiti run line. | |
llvm/test/CodeGen/AMDGPU/shift-select.ll | ||
2 | Please add another line for gfx1010. | |
57 | You also need tests for i64. | |
69 | Newline. |
I expected this to fix the test XFAIL'd in c12f046eb96f8462b3fd3889344ba344de5ace1f, but it seems to to have?
llvm/test/CodeGen/AMDGPU/shift-select.ll | ||
---|---|---|
57 | Would be LGTM if there were i64 tests. |
I haven't seen any tests XFAIL'd by this c12f046eb96f8462b3fd3889344ba344de5ace1f commit.
What did you mean? Could you explain please?
Any tests for GFX10 on this?