This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Type: ⇨ ∈; 🡺 ⇨ →
Needs ReviewPublic

Authored by sammccall on Jan 23 2020, 10:08 AM.

Details

Reviewers
kadircet
Summary

The blocky arrow is a fairly obscure character, and a couple of fonts I checked
don't have it :-(

"Type" is long and text-y, I do think people will get used to element-of (which
is very commonly present).

Diff Detail

Event Timeline

sammccall created this revision.Jan 23 2020, 10:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2020, 10:08 AM

Unit tests: fail. 62134 tests passed, 7 failed and 811 were skipped.

failed: Clangd.Clangd/hover.test
failed: Clangd Unit Tests._/ClangdTests/Hover.Present
failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongord/strongord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakeq/cmp.weakeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakord/weakord.pass.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.