This is an archive of the discontinued LLVM Phabricator instance.

[CMake][NFC] Refactor iOS simulator/device test configuration generation code for TSan.
ClosedPublic

Authored by delcypher on Jan 22 2020, 3:17 PM.

Details

Summary

The previous code hard-coded platform names but compiler-rt's CMake
build system actually already knows which Apple platforms TSan supports.

This change uses this information to enumerate the different Apple
platforms.

This change relies on the get_capitalized_apple_platform() function
added in a previous commit.

rdar://problem/58798733

Event Timeline

delcypher created this revision.Jan 22 2020, 3:17 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 22 2020, 3:17 PM
Herald added subscribers: Restricted Project, mgorny. · View Herald Transcript
delcypher updated this revision to Diff 239737.Jan 22 2020, 4:43 PM
  • Delete FIXME
  • space tweak
yln accepted this revision.Jan 23 2020, 11:23 AM
This revision is now accepted and ready to land.Jan 23 2020, 11:23 AM
This revision was automatically updated to reflect the committed changes.