Page MenuHomePhabricator

[CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan.
ClosedPublic

Authored by delcypher on Jan 22 2020, 2:29 PM.

Details

Summary

The previous code hard-coded platform names but compiler-rt's CMake
build system actually already knows which Apple platforms ASan supports.

This change uses this information to enumerate the different Apple
platforms.

rdar://problem/58798733

Diff Detail

Event Timeline

delcypher created this revision.Jan 22 2020, 2:29 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 22 2020, 2:29 PM
Herald added subscribers: Restricted Project, mgorny. · View Herald Transcript

@yln @kubamracek I changed my mind. I'm going to make this a NFC. It's probably a bad idea to couple the naming change with the refactor.

delcypher updated this revision to Diff 239712.Jan 22 2020, 3:09 PM

Make change NFC by not changing directory or lit test prefix.

delcypher retitled this revision from [CMake] Refactor iOS simulator/device test configuration generation code for ASan. to [CMake][NFC] Refactor iOS simulator/device test configuration generation code for ASan..Jan 22 2020, 3:10 PM
delcypher edited the summary of this revision. (Show Details)
yln accepted this revision.Thu, Jan 23, 11:23 AM
This revision is now accepted and ready to land.Thu, Jan 23, 11:23 AM
This revision was automatically updated to reflect the committed changes.