This is an archive of the discontinued LLVM Phabricator instance.

Differential D73224

[hip] Remove `-Werror=format-nonliteral`
ClosedPublic

Authored by hliao on Jan 22 2020, 1:09 PM.

Details

Reviewers
sameerds
yaxunl
ashi1
Commits
rG49f7bc9e1e50: [hip] Remove `-Werror=format-nonliteral`
Summary
  • It won't distinguish host and device code and trigger compilation failure on irrelevant code.

Diff Detail

Event Timeline

hliao created this revision.Jan 22 2020, 1:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 1:09 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B44624: Diff 239683.Jan 22 2020, 1:10 PM
hliao added a comment.Jan 22 2020, 1:11 PM

Have to remove this as it causes compilation failures on irrelevant host code during device compilation. Maybe we need to introduce a new warning option to issue that warning on device code only.

ashi1 accepted this revision.Jan 22 2020, 1:13 PM
This revision is now accepted and ready to land.Jan 22 2020, 1:13 PM
Closed by commit rG49f7bc9e1e50: [hip] Remove `-Werror=format-nonliteral` (authored by hliao). · Explain WhyJan 23 2020, 8:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
1 line
test/
Driver/
2 lines

Diff 239910

clang/lib/Driver/ToolChains/HIP.cpp

Show First 20 Lines • Show All 419 Lines • ▼ Show 20 Lines
Tool *HIPToolChain::buildLinker() const { Tool *HIPToolChain::buildLinker() const {
assert(getTriple().getArch() == llvm::Triple::amdgcn); assert(getTriple().getArch() == llvm::Triple::amdgcn);
return new tools::AMDGCN::Linker(*this); return new tools::AMDGCN::Linker(*this);
} }
void HIPToolChain::addClangWarningOptions(ArgStringList &CC1Args) const { void HIPToolChain::addClangWarningOptions(ArgStringList &CC1Args) const {
HostTC.addClangWarningOptions(CC1Args); HostTC.addClangWarningOptions(CC1Args);
CC1Args.push_back("-Werror=format-nonliteral");
} }
ToolChain::CXXStdlibType ToolChain::CXXStdlibType
HIPToolChain::GetCXXStdlibType(const ArgList &Args) const { HIPToolChain::GetCXXStdlibType(const ArgList &Args) const {
return HostTC.GetCXXStdlibType(Args); return HostTC.GetCXXStdlibType(Args);
} }
void HIPToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, void HIPToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs,
Show All 31 Lines

clang/test/Driver/hip-printf.hip

// REQUIRES: clang-driver // REQUIRES: clang-driver
// REQUIRES: x86-registered-target // REQUIRES: x86-registered-target
// REQUIRES: amdgpu-registered-target // REQUIRES: amdgpu-registered-target
// RUN: %clang -### -target x86_64-linux-gnu -x hip --cuda-gpu-arch=gfx900 \ // RUN: %clang -### -target x86_64-linux-gnu -x hip --cuda-gpu-arch=gfx900 \
// RUN: %s 2>&1 | FileCheck %s // RUN: %s 2>&1 | FileCheck %s
// CHECK: [[CLANG:".*clang.*"]] "-cc1" // CHECK: [[CLANG:".*clang.*"]] "-cc1"
// CHECK-SAME: "-Werror=format-nonliteral" // CHECK-NOT: "-Werror=format-nonliteral"