Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

[NFC][AArch64][SVE] Rename Destructive enumerator from DestructiveInstType
ClosedPublic
Actions

Authored by cameron.mcinally on Jan 22 2020, 9:59 AM.

Details

Reviewers

sdesmalen
kmclaughlin
dancgr
rengolin
efriedma

Commits

rG4f2e2acc4b2d: [NFC][AArch64][SVE] Rename Destructive enumerator from DestructiveInstType

Summary

This is the second patch in a collection to support prefixing destructive operations, with the MOVPRFX instruction, to build constructive operations. The previous patch is D73141.

This patch renames the Destructive enumerator, from the DestructiveInstType enum, to DestructiveOther.

The entirety of this patch comes from D71712.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

cameron.mcinally created this revision.Jan 22 2020, 9:59 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 9:59 AM

Herald added subscribers: llvm-commits, psnobl, rkruppe and 3 others. · View Herald Transcript

Ping.

LGTM!

llvm/lib/Target/AArch64/AArch64InstrFormats.td
29	nit: could this do with a comment on what DestructiveOther means? (something along the lines that it tells the instruction is destructive in its first source operand and can be movprfx'ed, but has no other special properties like commutativity or anything else)

This revision is now accepted and ready to land.Jan 29 2020, 8:12 AM

Closed by commit rG4f2e2acc4b2d: [NFC][AArch64][SVE] Rename Destructive enumerator from DestructiveInstType (authored by cameron.mcinally). · Explain WhyJan 29 2020, 1:49 PM

This revision was automatically updated to reflect the committed changes.

cameron.mcinally marked 2 inline comments as done.Jan 29 2020, 1:54 PM

cameron.mcinally added inline comments.