Page MenuHomePhabricator

[NFC][AArch64][SVE] Rename Destructive enumerator from DestructiveInstType
ClosedPublic

Authored by cameron.mcinally on Jan 22 2020, 9:59 AM.

Details

Summary

This is the second patch in a collection to support prefixing destructive operations, with the MOVPRFX instruction, to build constructive operations. The previous patch is D73141.

This patch renames the Destructive enumerator, from the DestructiveInstType enum, to DestructiveOther.

The entirety of this patch comes from D71712.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 9:59 AM
sdesmalen accepted this revision.Wed, Jan 29, 8:12 AM

LGTM!

llvm/lib/Target/AArch64/AArch64InstrFormats.td
29

nit: could this do with a comment on what DestructiveOther means? (something along the lines that it tells the instruction is destructive in its first source operand and can be movprfx'ed, but has no other special properties like commutativity or anything else)

This revision is now accepted and ready to land.Wed, Jan 29, 8:12 AM
This revision was automatically updated to reflect the committed changes.
cameron.mcinally marked 2 inline comments as done.Wed, Jan 29, 1:54 PM
cameron.mcinally added inline comments.
llvm/lib/Target/AArch64/AArch64InstrFormats.td
29

Is this ok with you? If not, I'll update with the next patch. I'm about to change a bunch of this stuff.