This is an archive of the discontinued LLVM Phabricator instance.

[llvm-cov] Add support for -skip-functions to lcov
ClosedPublic

Authored by keith on Jan 21 2020, 9:23 PM.

Details

Summary

This flag was added for the json format to exclude functions from the
output. This mirrors that behavior in lcov (where it was previously
accepted but ignored). This makes the output file smaller which can be
beneficial depending on how you consume it, especially if you don't use
this data anyways.

Patch by Keith Smiley (@keith).

Diff Detail

Event Timeline

keith created this revision.Jan 21 2020, 9:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2020, 9:23 PM
Dor1s accepted this revision.Jan 22 2020, 6:58 AM

LGTM

This revision is now accepted and ready to land.Jan 22 2020, 6:58 AM
allevato accepted this revision.Jan 22 2020, 7:14 AM

Can someone land this for me? I don't have permissions to do that AFAIK

Dor1s updated this revision to Diff 239674.Jan 22 2020, 12:49 PM

rebase + getting ready to commit

Dor1s edited the summary of this revision. (Show Details)Jan 22 2020, 12:51 PM
This revision was automatically updated to reflect the committed changes.