This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Custom lower G_LOG/G_LOG10
ClosedPublic

Authored by arsenm on Jan 21 2020, 7:31 PM.

Details

Reviewers
nhaehnle
kerbowa
Summary

I'm pretty sure this is wrong and we should expand these in a correct
way, but this matches the existing behavior.

Diff Detail

Event Timeline

arsenm created this revision.Jan 21 2020, 7:31 PM
nhaehnle accepted this revision.Jan 30 2020, 1:43 AM

LGTM relative to your other legalizer changes, though I wonder: shouldn't the old instructions be erased somehow? Other legalizer code seems to have the same problem, though I don't know how this is actually supposed to work.

This revision is now accepted and ready to land.Jan 30 2020, 1:43 AM

LGTM relative to your other legalizer changes, though I wonder: shouldn't the old instructions be erased somehow? Other legalizer code seems to have the same problem, though I don't know how this is actually supposed to work.

Yes. I apparently fixed this already after posting