This is an archive of the discontinued LLVM Phabricator instance.

Differential D72993

[NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating Alignment attr
ClosedPublic

Authored by lebedev.ri on Jan 19 2020, 2:09 AM.

Details

Reviewers
erichkeane
gchatelet
courbet
jdoerfert
Commits
rG6b2f820221c7: [NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating…
Summary

Just an NFC code cleanup i stumbled upon when stumbling through clang alignment attribute handling.

Diff Detail

Revision Contents

PathSize
clang/
lib/
CodeGen/
5 lines

Diff 239369

clang/lib/CodeGen/CGCall.cpp

Show First 20 Lines • Show All 2,434 Lines • ▼ Show 20 Lines case ABIArgInfo::Direct: {
if (AVAttr && !SanOpts.has(SanitizerKind::Alignment)) { if (AVAttr && !SanOpts.has(SanitizerKind::Alignment)) {
// If alignment-assumption sanitizer is enabled, we do *not* add // If alignment-assumption sanitizer is enabled, we do *not* add
// alignment attribute here, but emit normal alignment assumption, // alignment attribute here, but emit normal alignment assumption,
// so the UBSAN check could function. // so the UBSAN check could function.
llvm::Value *AlignmentValue = llvm::Value *AlignmentValue =
EmitScalarExpr(AVAttr->getAlignment()); EmitScalarExpr(AVAttr->getAlignment());
llvm::ConstantInt *AlignmentCI = llvm::ConstantInt *AlignmentCI =
cast<llvm::ConstantInt>(AlignmentValue); cast<llvm::ConstantInt>(AlignmentValue);
unsigned Alignment = std::min((unsigned)AlignmentCI->getZExtValue(), AI->addAttrs(llvm::AttrBuilder().addAlignmentAttr(llvm::MaybeAlign(
+llvm::Value::MaximumAlignment); AlignmentCI->getLimitedValue(llvm::Value::MaximumAlignment))));
AI->addAttrs(llvm::AttrBuilder().addAlignmentAttr(Alignment));
} }
} }
if (Arg->getType().isRestrictQualified()) if (Arg->getType().isRestrictQualified())
AI->addAttr(llvm::Attribute::NoAlias); AI->addAttr(llvm::Attribute::NoAlias);
// LLVM expects swifterror parameters to be used in very restricted // LLVM expects swifterror parameters to be used in very restricted
// ways. Copy the value into a less-restricted temporary. // ways. Copy the value into a less-restricted temporary.
▲ Show 20 Lines • Show All 2,217 Lines • Show Last 20 Lines