Page MenuHomePhabricator

[Codegen] Emit both AssumeAlignedAttr and AllocAlignAttr assumptions if they exist
ClosedPublic

Authored by lebedev.ri on Jan 18 2020, 10:10 AM.

Details

Summary

We shouldn't be just giving up if we find one of them
(like we currently do with AssumeAlignedAttr),
we should emit them all.

As the tests show, even if we materialized good knowledge
from __attribute__((assume_aligned(32), it doesn't mean
__attribute__((alloc_align([...]))) info won't be useful.
It might be, but that isn't given.

Diff Detail

Event Timeline

lebedev.ri created this revision.Jan 18 2020, 10:10 AM
lebedev.ri edited the summary of this revision. (Show Details)Jan 18 2020, 10:13 AM
erichkeane accepted this revision.Jan 21 2020, 7:46 AM
This revision is now accepted and ready to land.Jan 21 2020, 7:46 AM
This revision was automatically updated to reflect the committed changes.

Thank you for the review!